1092165 - Move SharedTypedArray tests from js/src/tests to js/src/jit-test

Status: RESOLVED WORKSFORME

(Core :: JavaScript Engine, defect, P2)

Description

[Lars T Hansen [:lth]]

In js/src/tests they are flagged as shell-only (maybe because they are Nightly-only?), so they won't be run on Try, nor during our normal dev testing.

There may be a reason why they are in js/src/tests in the first place, but most likely they are there just because the typedarray tests are there.

Comment 1

[Lars T Hansen [:lth]]

Attachment: Move the test cases and adapt to new location

Comment 2

[Jeff Walden [:Waldo]]

Why can't they just be marked as not shell-only?

Comment 3

[Lars T Hansen [:lth]]

(In reply to Jeff Walden [:Waldo] (remove +bmo to email) from comment #2)
> Why can't they just be marked as not shell-only?

I don't know.

Jandem suggested I move them, so I offered a patch that does, without thinking much about how I could change the tests to make them useful where they are.  I'm going to remove the review request and reconsider.

Comment 4

[Lars T Hansen [:lth]]

(In reply to Lars T Hansen [:lth] from comment #3)
> (In reply to Jeff Walden [:Waldo] (remove +bmo to email) from comment #2)
> > Why can't they just be marked as not shell-only?
> 
> I don't know.

See bug 1094269 for motivation.

Comment 5

[Lars T Hansen [:lth]]

SharedTypedArray is gone but the remaining test cases are about SharedArrayBuffer and really should be changed (somehow) so that they are properly run.

(It could be that they are shell-only because SharedArrayBuffer is not yet available in all channels but that seems feeble.)

Comment 6

[Lars T Hansen [:lth]]

Also bug 1094269 was closed as WONTFIX because test infra evolved to make the point moot.

Will investigate whether shell-only qualifier can be removed from tests in question, then be done here.

Comment 7

[Lars T Hansen [:lth]]

Probably some confusion, or code that has since changed: the qualifier on the file does not prevent testing on 'try'.  I added a bug in the file and pushed to try, and it fails as it should:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cb80d44acac4