1092187 - crash in mozilla::a11y::XULListboxAccessible::ColCount()

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect)

Description

[Marco Zehe (:MarcoZ)]

This bug was filed from the Socorro interface and is 
report bp-8691948f-9b87-425f-929d-a75fc2141031.
=============================================================

Ran into this after:
1. With Facebook open (although I don't think this matters), opened Tools/Options.
2. Tab to list of categories and select Security.
3. Tab to Saved Passwords and hit Space.
4. Enter a search string because I want to look up a password I had saved.
5. Tab to Show Passwords, and Yes the dialog that pops up.
6. Look up the saved password.
7. Press Ctrl+W to close tab.
8. landed back on categories list in Options, press Ctrl+W again to close tab.
9. Crash.

Comment 1

[Marco Zehe (:MarcoZ)]

It's even simpler than the above:

1. Tools/Options.
2. Tab to list of categories, focus is on "General.
3. Ctrl+W. Boom!

bp-22287a1d-c206-45ad-978b-23a902141031
bp-3d74d758-9cd4-4fad-8049-66c592141031

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

According to crash stats it seems to have appeared in build 20141023030203

Comment 3

[Marco Zehe (:MarcoZ)]

Then this could point to bug 1076816.

Note that I have to have keyboard focus in the list of categories on one of the items. If I tab into the settings themselves, like onto any of the checkboxes of the General page, for example, and then hit Ctrl+W, I don't get a crash.

Comment 4

[Marco Zehe (:MarcoZ)]

Regression window: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ae4d9b4ff2ee&tochange=88adcf8fef83

Comment 5

[alexander :surkov (:asurkov)]

Attachment: patch

it's not nice to change qi during object lifecycle but the object is supposed to be dead

Comment 6

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 8517673 [details] [diff] [review]
patch

Review of attachment 8517673 [details] [diff] [review]:
-----------------------------------------------------------------

r=me (we can't keep objects alive forever)

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0d1b17330735

Comment 8

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Socorro [1] shows no crashes on Firefox 36 over the past 4 weeks.

[1] - https://crash-stats.mozilla.com/report/list?product=Firefox&range_unit=days&range_value=28&signature=mozilla%3A%3Aa11y%3A%3AXULListboxAccessible%3A%3AColCount%28%29