Closed Bug 1092213 Opened 10 years ago Closed 10 years ago

Upgrade our use on moment.add()

Categories

(Webtools Graveyard :: Air Mozilla, defect)

Product:
Webtools Graveyard
Component:
Air Mozilla
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: peterbe, Assigned: lmcardle)

Details

(Whiteboard: [good first bug]) 

This use of moment().add() is deprecated and needs to be fixed. 
https://github.com/mozilla/airmozilla/blob/91c5e75b3493a410626295d39d4f75aff86533bc/airmozilla/base/static/js/base.js#L14

The new correct way would be::

    parsed.add(time_past, 'seconds');
Whiteboard: [good first bug]
Assignee: nobody → leo
Pull request: https://github.com/mozilla/airmozilla/pull/113
Status: NEW → ASSIGNED
Commit pushed to master at https://github.com/mozilla/airmozilla

https://github.com/mozilla/airmozilla/commit/fbee518dc65d858bc68e1a14ff491e40bae1e4ec
Merge pull request #113 from LeoMcA/master

Pull request for bug 1092213
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.