Closed Bug 1092219 Opened 10 years ago Closed 10 years ago

Fix keyedHistogram.add() passing the wrong argument to Histogram::Add()

Categories

(Toolkit :: Telemetry, defect)

Product:
Toolkit
Component:
Telemetry
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla36
Tracking Flags:
Tracking Status
firefox34 --- fixed
firefox35 --- fixed
firefox36 --- fixed

People

(Reporter: gfritzsche, Assigned: gfritzsche)

References

Details

Attachments

(1 file)

Fix
4.38 KB, patch
froydnj
: review+
lmandel
: approval-mozilla-aurora+
lmandel
: approval-mozilla-beta+
Details | Diff | Splinter Review
Attached patch Fix — — Splinter Review 
JSKeyedHistogram_Add() is currently converting & passing the wrong argument to Histogram::Add().
Attachment #8515071 - Flags: review?(nfroyd)
Attachment #8515071 - Flags: review?(nfroyd) → review+
Comment on attachment 8515071 [details] [diff] [review]
Fix

Approval Request Comment
[Feature/regressing bug #]: Search telemetry.
[User impact if declined]: Needed for bug 1069874.
[Describe test coverage new/current, TBPL]: automated tests.
[Risks and why]: Low, simple fix.
[String/UUID change made/needed]: None.
Attachment #8515071 - Flags: approval-mozilla-beta?
Attachment #8515071 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/238e8cc15a71
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Comment on attachment 8515071 [details] [diff] [review]
Fix

Beta+
Aurora+
Attachment #8515071 - Flags: approval-mozilla-beta?
Attachment #8515071 - Flags: approval-mozilla-beta+
Attachment #8515071 - Flags: approval-mozilla-aurora?
Attachment #8515071 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: