Active Accessibility: support <listbox>

RESOLVED FIXED in mozilla0.9.9

Status

P1
normal
RESOLVED FIXED
17 years ago
14 years ago

People

(Reporter: aaronlev, Assigned: mozilla)

Tracking

({access, sec508})

Trunk
mozilla0.9.9
x86
Windows 2000
access, sec508
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

17 years ago
A <listbox> can have multiple selections (sometimes? always?)

It's not implemented yet - see bug 70858
(Reporter)

Updated

17 years ago
Depends on: 70858
Keywords: access, fcc508
(Reporter)

Updated

17 years ago
Blocks: 82207
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → mozilla0.9.8
(Assignee)

Comment 1

17 years ago
to aaron per our discussion
Assignee: jgaunt → aaronl
Status: ASSIGNED → NEW
(Reporter)

Updated

17 years ago
Status: NEW → ASSIGNED
(Reporter)

Comment 2

17 years ago
-> back to jgaunt, since we have to wait for hewitt's fix on 70858
Assignee: aaronl → jgaunt
Status: ASSIGNED → NEW
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

17 years ago
Target Milestone: mozilla0.9.8 → mozilla0.9.9
(Reporter)

Updated

17 years ago
Keywords: nsbeta1
(Assignee)

Comment 3

17 years ago
Created attachment 68989 [details] [diff] [review]
v1.0 of patch for xul listbox accessibility

So far this is working everywhere except the doDefaultAction. That I can find
anyway. I'm still doing some poking.
(Assignee)

Comment 4

17 years ago
Created attachment 69703 [details] [diff] [review]
XUL listbox acc support
Attachment #68989 - Attachment is obsolete: true
(Reporter)

Comment 5

17 years ago
Comment on attachment 69703 [details] [diff] [review]
XUL listbox acc support

r=aaronl

Nits:

I take it that this patch fixes default actions for html selects as well?
What other bugs does this fix?

-    // add ourself as a RadiobuttonStateChange listener (custom event fired in
nsHTMLInputElement.cpp)

Why remove this comment instead of editing it and keeping it in there?

+    // may have to register as a nsIDOMXULListener for this same string

This comment is confusing. 

+//	 nsCOMPtr<nsIPresContext> presContext;
+//	 GetPresContext(presContext);
+//	if (presContext)
+//	 rv = content->HandleDOMEvent(presContext, &event, nsnull,
NS_EVENT_FLAG_INIT ,&status);

Do you want to remove commented out code?
In nsXULListboxAccessible::GetSelectedChildren()
I just noticed we have a superfluous return NS_OK; in the if statement right
before the end.
Attachment #69703 - Flags: review+
(Assignee)

Comment 6

17 years ago
Created attachment 69752 [details] [diff] [review]
cleaned up for r= nits

The html select work got in by mistake, taken out

fixed the comment about the radio button

took out the extra return and removed the commented out code as it really
doesn't apply
Attachment #69703 - Attachment is obsolete: true
(Reporter)

Updated

17 years ago
Attachment #69752 - Flags: review+

Comment 7

17 years ago
Comment on attachment 69752 [details] [diff] [review]
cleaned up for r= nits

sr=hewitt
Attachment #69752 - Flags: superreview+
(Assignee)

Comment 8

17 years ago
checked in last night/this morning with great fireworks
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.