1092234 - :: Block Grids Should Allow HTML Formatting

Status: RESOLVED FIXED

(Websites :: The Open Standard, defect)

Description

[Ben (:bensternthal)]

The block grid tags should allow html formatting (links, bold text etc)

Comment 1

[Joren Mathews]

Should be good now. Would be a good idea to confirm this on your local since DOMDocument has been finicky in the past.

Comment 2

[Ben (:bensternthal)]

Looks good locally but let's double check on dev post merge.

Comment 3

[Ben (:bensternthal)]

Does not appear to work on stage. See

https://openstandard.allizom.org/test-need-an-imitation-rat-skeleton-theres-a-3d-print-file-for-that/

Renders an empty P tag

Comment 4

[Joren Mathews]

Can you get me the the source of the wysiwyg editor that produces that output? (Text tab on top right of the editor)

Comment 5

[Ben (:bensternthal)]

Attachment: test-post.txt

Here is the source of that post.

Comment 6

[Joren Mathews]

What PHP version is stage using?

Comment 7

[Ben (:bensternthal)]

Stage and prod were reported to me as using  PHP 5.3.3

Comment 8

[Joren Mathews]

Ok. Since we've had such trouble with straight DomDocument methods, I implemented a lib for manipulating the DOM. Hopefully this works on stage.

Comment 9

[Ben (:bensternthal)]

I did not see a new PR for this? Can you commit the code in a new pr and I can test.

I have 5.3.3 working locally now.

Comment 10

[Ben (:bensternthal)]

Here are the errors that appear locally:

[31-Dec-2014 23:06:23 UTC] PHP Warning:  DOMDocumentFragment::appendXML() [<a href='domdocumentfragment.appendxml'>domdocumentfragment.appendxml</a>]:  Test Bullet gamma in /Users/bsternthal/Documents/Dev/theopenstandard/themes/theopenstandard/content-filters.php on line 22
[31-Dec-2014 23:06:23 UTC] PHP Warning:  DOMDocumentFragment::appendXML() [<a href='domdocumentfragment.appendxml'>domdocumentfragment.appendxml</a>]:                   ^ in /Users/bsternthal/Documents/Dev/theopenstandard/themes/theopenstandard/content-filters.php on line 22
[31-Dec-2014 23:06:23 UTC] PHP Warning:  DOMNode::appendChild() [<a href='domnode.appendchild'>domnode.appendchild</a>]: Document Fragment is empty in /Users/bsternthal/Documents/Dev/theopenstandard/themes/theopenstandard/content-filters.php on line 87

Comment 11

[Joren Mathews]

Created the PR. See if that fixes.

Comment 12

[Ben (:bensternthal)]

Tested locally with PR. Everything works as expected on php 5.3.X and there were no errors in the log file.


Merged.