1092248 - Splinter renders to an empty page with my Nightly profile

Status: RESOLVED WORKSFORME

(bugzilla.mozilla.org :: Splinter, defect)

Description

[Gregory Szorc [:gps]]

Attachment: screen shot.png

Starting yesterday, trying to conduct code review using Splinter renders a mostly empty page. (See attached screen shot.)

I have tried the following mitigation strategies with no success:

* Restarting Nightly in safe mode, with add-ons disabled
* Logging out and back into Bugzilla
* Clearing my cookies for bugzilla.mozilla.org
* Clearing my browser cache and offline data

What *does* work is starting a fresh Nightly profile.

Huh?

Looking at the web console, I do see an error:

SyntaxError: JSON.parse: expected double-quoted property name at line 1 column 131234 of the JSON data 10d39aa75fd233eb12f252bf61acbd28.js:25

This is in some obfuscated script.

I'm not sure what's going on. I figured I should file a bug.

Possibly related: I *think* this problem started occurring after my Nightly crashed yesterday while surfing Bugzilla. That crash report is at https://crash-stats.mozilla.com/report/index/c2628ded-d423-4cac-8fdf-b0cbd2141030

Comment 1

[David Lawrence [:dkl]]

Which bug id is it so I can look at the patch that is crashing Splinter? I can also turn off minification locally and get a better idea where the JS error is occurring.

dkl

Comment 2

[David Lawrence [:dkl]]

(In reply to David Lawrence [:dkl] from comment #1)
> Which bug id is it so I can look at the patch that is crashing Splinter? I
> can also turn off minification locally and get a better idea where the JS
> error is occurring.
> 
> dkl

Oh, and nothing has change in Splinter in quite some time so I think it is just a patch it doesn't like.

dkl

Comment 3

[Gregory Szorc [:gps]]

I'm seeing this on every review link AFAICT.

https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=1092217&attachment=8515068
https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=1091383&attachment=8514028

I clicked on that latter one late Wednesday and it rendered fine. I can also go back to previous reviews I've performed and Splinter is broken on every one.

I'm pretty sure my Nightly profile is in some kind of weird state.

Comment 4

[Gregory Szorc [:gps]]

The HTML being pulled down looks sane. I think that JavaScript error is killing things.

If I set the Firefox devtools to break on error, I find the exception being raised in:

YAHOO.util.Attribute.prototype.getValue():

  getValue: function () {
    var a = this.value;
    if (this.getter) {
      a = this.getter.call(this.owner, this.name, a);
    }
    return a;
  },

There is a YAHOO.lang.JSON.parse involved here. The calling code appears to be Splinter.ReviewStorage.LocalReviewStorage.prototype._init().

The failing JSON blob appears to be:

[{"bugId":448069,"bugShortDesc":"Add xulrunner tests","attachmentId":825142,"attachmentDescription":"xulrunner-testlaunch.diff","creationTime":1383762456715,"modificationTime":1383762517962,"filesReviewed":{},"isDraft":true},{"bugId":933145,"bugShortDesc":"Skip directories without variables in moz.build that are relevant to compile or binaries during those tiers","attachmentId":825208,"attachmentDescription":"Skip directories without variables in moz.build that are relevant to compile or binaries during those tiers","creationTime":1383764393657,"modificationTime":1383764393657,"isDraft":false},{"bugId":933176,"bugShortDesc":"Skip \"obviously\" non-tools directories during the tools tier","attachmentId":826254,"attachmentDescription":"Skip non-tools directories without variables in moz.build that are relevant to tools during this tier","creationTime":1383765065952,"modificationTime":1383765065952,"isDraft":false},{"bugId":921816,"bugShortDesc":"idls are not handled in --with-libxul-sdk 

I'm not sure if the Firefox devtools are truncating or if that string really is truncated.

I see a reference to localStorage in the Splinter function. I'm going to poke around that database to see if there is corruption...

Comment 5

[Gregory Szorc [:gps]]

Blowing away my localStorage values for bugzilla.mozilla.org resolved the problem.

I saved a copy of the SQLite database (presumably with the bad values triggering this bug). I could probably send a dump of my bugzilla.mozilla.org values if you want.

Please needinfo me for the data or close out this bug.

Comment 6

[David Lawrence [:dkl]]

I do not get any error on both attachments when viewing using latest stable 33.0 and given that you are able to make it work with when blowing away the old localeStorage we should be able to close this. I would attach the broken dump for historical/research reasons but given this is the first I have personally heard this happening and have not encountered it ever myself, my gut tells me it is not really a Splinter bug.

dkl