Closed Bug 1092274 Opened 10 years ago Closed 8 years ago

[backend] Alert Manager - fix the merge detection code

Categories

(Testing :: General, defect)

Product:
Testing
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: jmaher, Unassigned, Mentored)

References

Details

(Whiteboard: [good next bug][lang=python]) 

In alertmanager we receive a bunch of alerts from talos and graph server.  These are usually interesting alerts which sometimes result in bugs.  When we merge code from one branch to another it ends up causing duplicate alerts.  We want to handle this case by flagging alerts as merged.

in the code https://github.com/jmaher/alert_manager/blob/master/parse_news.py, we take a given alert which has come in and see if an existing alert is contains a subset of changesets and is a similar alert.  If this is the case, we mark it as mergedfrom on the keyrevision field and move on.  When the UI sees this, we don't display mergedfrom alerts by default and can easily mark them as merged.

This has been broken for a few weeks, in fact the code appears to be correct, but I suspect the data coming from the database is in an array, list, dict or some other data type.
Hi, I'd like to take this up.
Hi :dorsatum, it will be fun working with you on this.  If you read over https://wiki.mozilla.org/Auto-tools/Projects/AlertManager, you can see how to set this up.  It is fairly straightforward, but sometimes we end up with random issues.

The merge detection code does work in some cases, we need to analyze this and make it better.  I will caution you that this might take a bit of trial and error and there will be a lot of learning- easy to view it as a larger challenge!
Hi :jmaher, I'm sorry for taking so much time to reply. My m-c build had errors that took a really long time to fix. Is there an irc channel on which I could speak to you about this bug?
In #ateam for example, you can chat with :jmaher.
thanks ;mwargers.  :dorsatum, I look forward to chatting with you.  I won't be around irc today, but will be a little bit tomorrow.
alert manager is has been replaced by perfherder
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.