Closed Bug 1092378 Opened 10 years ago Closed 9 years ago

<video> poster image doesn't render, if it lacks an intrinsic size (e.g. because it's an SVG image w/ no width or height attr)

Categories

(Core :: Layout, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla36

People

(Reporter: dholbert, Unassigned)

References

Details

Attachments

(2 files)

Attached file testcase 1
STR:
 1. Load attached testcase.

EXPECTED RESULTS:
Each <video> should render some lime, for the poster image.

ACTUAL RESULTS:
The first two <video> elements are blank -- no poster image is displayed. Only the third (where the SVG image has an intrinsic size) ends up rendering.
Attached file reference case 1
Here's a reference for testcase 1, which just uses <embed src> instead of <video poster>.

(Chrome doesn't have this bug, FWIW; they render the testcase like the reference case.)
This happens in part because we check the image's "natural height" & "natural width" before we give it a (nonzero) scaled size:
http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsVideoFrame.cpp#299

 --> Adding dependency on bug 517363, which added those checks.

I don't think these checks should really be necessary. I'll probably be removing them in bug 624647, so that bug will likely fix this.
 --> Adding dependency on bug 624647 since it'll likely fix this.
Depends on: 517363, 624647
Summary: <video> poster image doesn't render, if it lacks an no intrinsic size (e.g. because it's SVG w/ no width attr) → <video> poster image doesn't render, if it lacks an intrinsic size (e.g. because it's an SVG image w/ no width or height attr)
(In reply to Daniel Holbert [:dholbert] from comment #2)
>  --> Adding dependency on bug 624647 since it'll likely fix this.

I verified that it did fix this -- this bug is broken in the 2014-11-15 nightly, and working in the 2014-11-16 nightly (the first with bug 624647 fixed).

Hence, resolving as FIXED by bug 624647, w/ same target-milestone.

Probably worth checking in a regression test (e.g. just the testcases here with the text removed). Setting "in-testsuite?" to hopefully remind myself or someone else to do that.
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
QA Whiteboard: [good first verify]
Reproduced the issue on Firefox 36 Nightly (build id: 20141031061804).
On Firefox 36 Beta 7, testcase 1 renders like the reference case 1, so verified as fixed on Firefox 36 Beta 7 (build id: 20150205114429), under Ubuntu 12.04 64bit.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: