Closed
Bug 1092389
Opened 10 years ago
Closed 10 years ago
Cannot initiate CDMA three-way call
Categories
(Firefox OS Graveyard :: Gaia::Dialer, defect)
Tracking
(blocking-b2g:2.1+, b2g-v2.1 fixed, b2g-v2.2 fixed)
People
(Reporter: mschwart, Assigned: drs)
Details
Attachments
(1 file, 1 obsolete file)
|
3.64 KB,
patch
|
gsvelto
:
review+
bajaj
:
approval-gaia-v2.1+
|
Details | Diff | Splinter Review |
[Blocking Requested - why for this release]: found on 2.1 https://bugzilla.mozilla.org/show_bug.cgi?id=970187 added a check to determine if the network mode is CDMA [1] but it is missing a case for 'ehrpd' [2]. [1] http://mxr.mozilla.org/gaia/source/apps/communications/dialer/js/telephony_helper.js#49 [2] http://mxr.mozilla.org/mozilla-central/source/dom/webidl/MozMobileConnectionInfo.webidl#8 I have prepared a simple fix but I think this shows the need for a getNetworkFamily() function (or something of the like) in MozMobileConnection.
|
Reporter | |
Comment 1•10 years ago
|
||
Attachment #8515322 -
Flags: review?(drs.bugzilla)
|
||
Comment 2•10 years ago
|
||
(In reply to Michael Schwartz [:m4] from comment #0) > I have prepared a simple fix but I think this shows the need for a > getNetworkFamily() function (or something of the like) in > MozMobileConnection. Agreed. Please also add a unit-test to cover this scenario.
|
|
Reporter | |
Comment 3•10 years ago
|
||
(In reply to Gabriele Svelto [:gsvelto] from comment #2) > Please also add a unit-test to cover this scenario. Sorry but I won't be able to do that. Perhaps you could do that for me? Fair trade for the cases we test for you guys ;)
|
Assignee | |
Comment 4•10 years ago
|
||
Assignee: nobody → drs.bugzilla
Attachment #8515322 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8515322 -
Flags: review?(drs.bugzilla)
Attachment #8515663 -
Flags: review?(gsvelto)
|
|
Assignee | |
Updated•10 years ago
|
Target Milestone: --- → 2.1 S8 (7Nov)
|
|
||
Comment 5•10 years ago
|
||
Comment on attachment 8515663 [details] [diff] [review] Add 'ehrpd' to list of CDMA network modes. Review of attachment 8515663 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, thanks to both!
Attachment #8515663 -
Flags: review?(gsvelto) → review+
|
|
Assignee | |
Comment 6•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/0bcc5667de9f8d6d751d107033eba8d8ce65aee1
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-b2g-v2.1:
--- → affected
status-b2g-v2.2:
--- → fixed
Resolution: --- → FIXED
|
|
Assignee | |
Comment 7•10 years ago
|
||
Comment on attachment 8515663 [details] [diff] [review] Add 'ehrpd' to list of CDMA network modes. [Approval Request Comment] [Bug caused by] (feature/regressing bug #): Probably never worked. [User impact] if declined: Users on 'ehrpd' CDMA type will be treated as GSM, so actions like placing calls will be broken for them under certain circumstances. [Testing completed]: Michael tested this. [Risk to taking this patch] (and alternatives if risky): Very low. [String changes made]: None.
Attachment #8515663 -
Flags: approval-gaia-v2.1?(release-mgmt)
|
||
Updated•10 years ago
|
Attachment #8515663 -
Flags: approval-gaia-v2.1?(release-mgmt) → approval-gaia-v2.1+
|
||
Comment 9•10 years ago
|
||
v2.1: https://github.com/mozilla-b2g/gaia/commit/9d80d556123553e5fd8acd982192e33807e9e1fe
|
||
Comment 10•10 years ago
|
||
Unable to verify don't have CDMA devices
QA Whiteboard: [QAnalyst-Triage?][QAnalyst-verify-]
Flags: needinfo?(ktucker)
|
||
Updated•10 years ago
|
QA Whiteboard: [QAnalyst-Triage?][QAnalyst-verify-] → [QAnalyst-Triage+][QAnalyst-verify-]
Flags: needinfo?(ktucker)
You need to log in
before you can comment on or make changes to this bug.
Description
•