Closed Bug 1092409 Opened 5 years ago Closed 5 years ago

Enable share overlay in release channels

Categories

(Firefox for Android :: Overlays, defect)

All
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 36
Tracking Status
firefox34 --- wontfix
firefox35 --- verified
firefox36 --- verified

People

(Reporter: rnewman, Assigned: rnewman)

References

Details

Attachments

(1 file)

We should decide when we want to turn this on. Right now the code is in Beta 34, but hidden behind a release flag. I think 35 is good to go.

34 might be, too, if we uplift one or two bugs. (Do an `hg log` on the overlay dir in Aurora to get a list.)

Needinfo on Deb and Mark to make a call.
Flags: needinfo?(mark.finkle)
Flags: needinfo?(deb)
Some patches on Aurora that might need to be pushed top Beta:
Bug 1073010: Allow browsing from share overlay
Bug 1067543: Hide reading list add button from overlay on low memory devices
Bug 1068051: Add high-res device drawables

The frustrating part of this is the first two bugs are tracking 34+, but just didn't get uplifted.

The patches look safe enough for uplift to me. No strings either.

Richard - Are these the bugs you were thinking baout? I will request uplift to 34 right away.
Flags: needinfo?(mark.finkle)
I requested uplift for these 3 patches. If we get it early next week, we should enable this on Fx34.

Can we get an "Enable this" patch ready to go for Fx34?
Flags: needinfo?(rnewman)
I needed these, too:

 0 A b0c0a3322e36: Bug 1061384: Colour tweaks for the share overlay. r=rnewman
 1 A d996743af7a3: Bug 1061721: Handle items already in bookmarks/reading list in overlays. r=rnewman
 2 A 2bcd3d508fe4: Bug 1066747: Fix strictmode violation in sharing service. r=rnewman

Doing a test build now.
Flags: needinfo?(rnewman)
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
(In reply to Richard Newman [:rnewman] from comment #3)
> I needed these, too:
> 
>  0 A b0c0a3322e36: Bug 1061384: Colour tweaks for the share overlay.
> r=rnewman
>  1 A d996743af7a3: Bug 1061721: Handle items already in bookmarks/reading
> list in overlays. r=rnewman
>  2 A 2bcd3d508fe4: Bug 1066747: Fix strictmode violation in sharing service.
> r=rnewman
> 
> Doing a test build now.

Are you planning to request approval for these?
Yes. I was expecting my test build to work, but that Skia build issue isn't fixed, and the backout mentioned in IRC logs didn't fix my builds, so I'm waiting for a Try push.

I'll request uplift for those in the mean time.
Last try build is green, with the five dependencies plus this bug.

Testing by hand now.
Bug 1061721 adds strings.
No longer depends on: 1061721
Given that we're already late in Beta, I would prefer to see this feature work ride the 35 train rather than risk introducing a regression in 34. Bug 1061721 also includes string changes that we can't take in 34.

Deb - Are you ok shipping this feature in 35?
Blocks: 948509
Comment on attachment 8515657 [details] [diff] [review]
Enable share overlay in release channels.

At the very least this needs to land in Aurora, so that when it merges to Beta the feature doesn't turn off.
Attachment #8515657 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/d05c56b27e4b
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Flags: needinfo?(deb)
Attachment #8515657 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
This feature is now slated for Fx35
Share overlay is enabled in both builds Firefox for Android 36.0a2 (2014-12-04) and Firefox for Android 35 Beta 1 build 2, so I will mark this as verified fixed.
Device: Nexus 4 (Android 4.4.4)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.