1092447 - webcompat "Report Site Issue" is not always enabled

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Christian Ascheberg]

The "Report Site Issue" menu item is not always enabled, I see this problem on http://www.golem.de and http://m.heise.de

STR:
- open one of the mentioned websites
- check the "Report Site Issue" menu item

Result:
- menu item is not enabled

If I open the menu quickly, I see that initially the menu item is disabled, then changes to enabled while the website is loading, but becomes disabled again as soon as the website finishes loading

Comment 1

[Aaron Train [:aaronmt]]

I see this. Perhaps there's a conditional not met on a site like Golem.de

Comment 2

[Mike Taylor [:miketaylr]]

Ah, OK. They're probably loading some iframes with src set to "about:blank".

I/GeckoConsole(29813): CURRENT URI http://tpc.googlesyndication.com/safeframe/1-0-0/html/container.html
I/GeckoConsole(29813): isReportableUrl true
I/GeckoConsole(29813): CURRENT URI http://tpc.googlesyndication.com/safeframe/1-0-0/html/container.html
I/GeckoConsole(29813): isReportableUrl true
I/GeckoConsole(29813): CURRENT URI about:blank
I/GeckoConsole(29813): isReportableUrl false
I/GeckoConsole(29813): CURRENT URI http://googleads.g.doubleclick.net/pagead/drt/s?v=r20120211
I/GeckoConsole(29813): isReportableUrl true
I/GeckoConsole(29813): CURRENT URI http://m.heise.de/
I/GeckoConsole(29813): isReportableUrl true
I/GeckoConsole(29813): CURRENT URI https://googleads.g.doubleclick.net/pagead/drt/si?p=CAA&ut=AFAKxlQAAAAAVFeokzut37oz8c3mmy4CQ61IfIMn4rNN
I/GeckoConsole(29813): isReportableUrl true
W/GeckoConsole(29813): [JavaScript Error: "a248.e.akamai.net : server does not support RFC 5746, see CVE-2009-3555"]
W/GeckoConsole(29813): [JavaScript Error: "a248.e.akamai.net : server does not support RFC 5746, see CVE-2009-3555"]
I/GeckoConsole(29813): CURRENT URI http://m.heise.de/
I/GeckoConsole(29813): isReportableUrl true
I/GeckoConsole(29813): CURRENT URI about:blank
I/GeckoConsole(29813): isReportableUrl false

Comment 3

[Mike Taylor [:miketaylr]]

Attachment: 1092447.patch

This patch makes sure we don't toggle the menu's enabled state for non top-level documents. 

I also changed from observing "content-page-shown" to chrome/content-document-global-created, because chrome docs like about:firefox don't emit "content-page-shown" (which means they would never be disabled).

Comment 4

[:Margaret Leibovic]

Comment on attachment 8516201 [details] [diff] [review]
1092447.patch

Review of attachment 8516201 [details] [diff] [review]:
-----------------------------------------------------------------

I haven't seen these 2 events before, but briefly looking through the tree, they sound like what we want here :)

Comment 5

[Mike Taylor [:miketaylr]]

Yeah, I had to do a bunch of logging just to be sure. :P Thanks for the review.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/1ac74d8cff3b

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1ac74d8cff3b