Closed Bug 1092451 Opened 10 years ago Closed 10 years ago

Intermittent e10s browser_wa_reset-04.js | We have both frames in the list - Got 0, expected 2 | Got an error: frameBtns[1] is undefined | Found an unexpected tab at the end of test run

Categories

(DevTools Graveyard :: Web Audio Editor, defect)

Product:
DevTools Graveyard
Component:
Web Audio Editor
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(e10s+, firefox34 unaffected, firefox35 unaffected, firefox36 fixed, firefox-esr31 unaffected)

Status:
RESOLVED FIXED
Milestone:
Firefox 36
Tracking Flags:
Tracking Status
e10s + ---
firefox34 --- unaffected
firefox35 --- unaffected
firefox36 --- fixed
firefox-esr31 --- unaffected

People

(Reporter: RyanVM, Assigned: ochameau)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

patch v2
2.49 KB, patch
past
: review+
Details | Diff | Splinter Review 
14:55:25     INFO -  2869 INFO TEST-START | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_reset-04.js
14:55:27     INFO -  JavaScript warning: chrome://browser/content/devtools/d3.js, line 479: mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with the correct initial [[Prototype]] value using Object.create
14:55:27     INFO -  2870 INFO checking window state
14:55:27     INFO -  2871 INFO Initializing a web audio editor pane.
14:55:27     INFO -  2872 INFO Adding tab: http://example.com/browser/browser/devtools/webaudioeditor/test/doc_iframe-context.html
14:55:27     INFO -  2873 INFO Tab added and finished loading: http://example.com/browser/browser/devtools/webaudioeditor/test/doc_iframe-context.html
14:55:27     INFO -  2874 INFO Console message: [JavaScript Warning: "mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with the correct initial [[Prototype]] value using Object.create" {file: "chrome://browser/content/devtools/d3.js" line: 479}]
14:55:27     INFO -  2875 INFO TEST-PASS | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_reset-04.js | The 'reload this page' notice should initially be visible.
14:55:27     INFO -  2876 INFO TEST-PASS | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_reset-04.js | The 'waiting for an audio context' notice should initially be hidden.
14:55:27     INFO -  2877 INFO TEST-PASS | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_reset-04.js | The tool's content should initially be hidden.
14:55:27     INFO -  2878 INFO TEST-PASS | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_reset-04.js | The frame list button is visible
14:55:27     INFO -  2879 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_reset-04.js | We have both frames in the list - Got 0, expected 2
14:55:27     INFO -  Stack trace:
14:55:27     INFO -      chrome://mochikit/content/browser-test.js:test_is:828
14:55:27     INFO -      chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_reset-04.js:spawnTest:31
14:55:27     INFO -      self-hosted:next:913
14:55:27     INFO -      test@chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/head.js:125:3
14:55:27     INFO -      Tester_execTest@chrome://mochikit/content/browser-test.js:674:9
14:55:27     INFO -      Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:571:7
14:55:27     INFO -      SimpleTest.waitForFocus/maybeRunTests/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:683:49
14:55:27     INFO -  *************************
14:55:27     INFO -  A coding exception was thrown and uncaught in a Task.
14:55:27     INFO -  Full message: TypeError: frameBtns[1] is undefined
14:55:27     INFO -  Full stack: spawnTest@chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_reset-04.js:34:3
14:55:27     INFO -  test@chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/head.js:125:3
14:55:27     INFO -  Tester_execTest@chrome://mochikit/content/browser-test.js:674:9
14:55:27     INFO -  Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:571:7
14:55:27     INFO -  SimpleTest.waitForFocus/maybeRunTests/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:683:49
14:55:27     INFO -  *************************
14:55:27     INFO -  2880 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_reset-04.js | Got an error: frameBtns[1] is undefined
14:55:27     INFO -  spawnTest@chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_reset-04.js:34:3
14:55:27     INFO -  test@chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/head.js:125:3
14:55:27     INFO -  Tester_execTest@chrome://mochikit/content/browser-test.js:674:9
14:55:27     INFO -  Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:571:7
14:55:27     INFO -  SimpleTest.waitForFocus/maybeRunTests/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:683:49
14:55:27     INFO -   -
14:55:27     INFO -  Stack trace:
14:55:27     INFO -  chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/head.js:handleError:88
14:55:27     INFO -  resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:Handler.prototype.process:871
14:55:27     INFO -  resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:this.PromiseWalker.walkerLoop:747
14:55:27     INFO -  null:null:0
14:55:28     INFO -  2881 INFO TEST-OK | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_reset-04.js | took 2415ms
14:55:28     INFO -  2882 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_reset-04.js | Found an unexpected tab at the end of test run: http://example.com/browser/browser/devtools/webaudioeditor/test/doc_iframe-context.html - expected PASS
Assignee: nobody → jsantell
Pinging Alex, as he's the one who wrote this test, not sure what the frame switching stuff is
Assignee: jsantell → nobody
Flags: needinfo?(poirot.alex)
Attached patch patch (obsolete) — — Splinter Review 
I'm not 100% sure it will fix this intermittent as I wasn't able to reproduce it locally.
It seems to only happen on e10s.
But that patch should fix a potential, but harmless for end user, race condition.

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=d9e1a45a8641
Assignee: nobody → poirot.alex
Flags: needinfo?(poirot.alex)
Attached patch patch v2 — — Splinter Review 
Fixed deferred.resolve() instead of promise.resolve()...

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=99ced86d3b70
Attachment #8516051 - Attachment is obsolete: true
Comment on attachment 8516246 [details] [diff] [review]
patch v2

Review of attachment 8516246 [details] [diff] [review]:
-----------------------------------------------------------------

Panos, you reviewed the original patch, but feel free to redirect the review to :jryans if you are overloaded ;)
Attachment #8516246 - Flags: review?(past)
Comment on attachment 8516246 [details] [diff] [review]
patch v2

Review of attachment 8516246 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8516246 - Flags: review?(past) → review+
Multiple try runs stay green, hopefully it will fix it for good!
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/92073635b516
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/92073635b516
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: