Closed
Bug 1092452
Opened 11 years ago
Closed 11 years ago
Intermittent browser_timeline_overview-initial-selection-02.js | The initial selection start is correct. | The initial selection end is correct.
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
Tracking
(e10s+, firefox34 unaffected, firefox35 fixed, firefox36 fixed, firefox-esr31 unaffected)
RESOLVED
FIXED
Firefox 36
| Tracking | Status | |
|---|---|---|
| e10s | + | --- |
| firefox34 | --- | unaffected |
| firefox35 | --- | fixed |
| firefox36 | --- | fixed |
| firefox-esr31 | --- | unaffected |
People
(Reporter: RyanVM, Assigned: sjakthol)
References
(Blocks 1 open bug)
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
|
1.33 KB,
patch
|
vporof
:
review+
|
Details | Diff | Splinter Review |
17:38:43 INFO - 2795 INFO TEST-START | chrome://mochitests/content/browser/browser/devtools/timeline/test/browser_timeline_overview-initial-selection-02.js
17:38:47 INFO - 2796 INFO checking window state
17:38:47 INFO - 2797 INFO Initializing a timeline pane.
17:38:47 INFO - 2798 INFO Adding tab: http://example.com/browser/browser/devtools/timeline/test/doc_simple-test.html
17:38:47 INFO - 2799 INFO Tab added and finished loading: http://example.com/browser/browser/devtools/timeline/test/doc_simple-test.html
17:38:47 INFO - 2800 INFO TEST-PASS | chrome://mochitests/content/browser/browser/devtools/timeline/test/browser_timeline_overview-initial-selection-02.js | Recording has started.
17:38:47 INFO - 2801 INFO TEST-PASS | chrome://mochitests/content/browser/browser/devtools/timeline/test/browser_timeline_overview-initial-selection-02.js | Recording has ended.
17:38:47 INFO - 2802 INFO TEST-PASS | chrome://mochitests/content/browser/browser/devtools/timeline/test/browser_timeline_overview-initial-selection-02.js | There are no markers available.
17:38:47 INFO - 2803 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/timeline/test/browser_timeline_overview-initial-selection-02.js | The initial selection start is correct. - Got 84.6339752193561, expected null
17:38:47 INFO - Stack trace:
17:38:47 INFO - chrome://mochikit/content/browser-test.js:test_is:828
17:38:47 INFO - chrome://mochitests/content/browser/browser/devtools/timeline/test/browser_timeline_overview-initial-selection-02.js:test<:25
17:38:47 INFO - self-hosted:next:883
17:38:47 INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:674:9
17:38:47 INFO - Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:571:7
17:38:47 INFO - SimpleTest.waitForFocus/maybeRunTests/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:683:49
17:38:47 INFO - 2804 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/timeline/test/browser_timeline_overview-initial-selection-02.js | The initial selection end is correct. - Got 257.2839752193561, expected null
17:38:47 INFO - Stack trace:
17:38:47 INFO - chrome://mochikit/content/browser-test.js:test_is:828
17:38:47 INFO - chrome://mochitests/content/browser/browser/devtools/timeline/test/browser_timeline_overview-initial-selection-02.js:test<:27
17:38:47 INFO - self-hosted:next:883
17:38:47 INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:674:9
17:38:47 INFO - Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:571:7
17:38:47 INFO - SimpleTest.waitForFocus/maybeRunTests/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:683:49
17:38:47 INFO - 2805 INFO TEST-OK | chrome://mochitests/content/browser/browser/devtools/timeline/test/browser_timeline_overview-initial-selection-02.js | took 3847ms
| Comment hidden (Legacy TBPL/Treeherder Robot) |
Updated•11 years ago
|
Blocks: e10s-tests
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Assignee | ||
Comment 13•11 years ago
|
||
It appears that I was wrong with the fix of bug 1067287: the test requires that the marker arrays are empty both before and after calling _stopRecording. It probably only appears in e10s as there's IPC overhead giving
This bug is probably caused by following chain of events:
1. Recording starts
2. Server pushes some markers to the client.
3. Test continues executing and executes following call chain:
> _stopRecordingAndDiscardData
> _stopRecording
> handleRecordingEnded
4. In handleRecordingEnded, on lines 344-352, the true branch is taken. This causes the selection start and end to be something other than the test expects.
Here's a try run: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=347625158801
Updated•11 years ago
|
Attachment #8522977 -
Flags: review?(vporof) → review+
| Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
| Reporter | ||
Comment 14•11 years ago
|
||
Comment 15•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
| Reporter | ||
Comment 16•11 years ago
|
||
status-firefox34:
--- → unaffected
status-firefox35:
--- → fixed
status-firefox36:
--- → fixed
status-firefox-esr31:
--- → unaffected
Comment 17•11 years ago
|
||
Sorry for the spam. Moving bugs to Firefox :: Developer Tools: Performance Tools (Profiler/Timeline).
dkl
Component: Developer Tools: Timeline → Developer Tools: Performance Tools (Profiler/Timeline)
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•