1092526 - about:downloads needs CSS styles on each platforms

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Comment 1

[Richard Marti (:Paenglab)]

Attachment: aboutDownloadsStyles.patch

All styles are taken from Firefox.

I've also added a icon for the tab.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8515488 [details] [diff] [review]
aboutDownloadsStyles.patch

Review of attachment 8515488 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine to me - though I think that a good chunk of the .css can probably be de-duped and put into mail/themes/shared instead.

::: mail/themes/linux/mail/downloads/aboutDownloads.css
@@ +3,5 @@
> + * You can obtain one at http://mozilla.org/MPL/2.0/. */
> +
> +/*** Panel and outer controls ***/
> +
> +#aboutDownloads {

Seems to me that a lot of this css could probably be put under mail/themes/shared, no?

Comment 3

[Richard Marti (:Paenglab)]

Attachment: aboutDownloadsStyles.patch

Yes, you are right. Now with shared aboutDownloads.css.

Comment 4

[Josiah Bruner [:jsbruner]]

Comment on attachment 8542678 [details] [diff] [review]
aboutDownloadsStyles.patch

Review of attachment 8542678 [details] [diff] [review]:
-----------------------------------------------------------------

Seems fine to me, but the OS X icon seems wrong to me. I'm guessing it looks a lot nicer on other platforms. It's slightly blurry and perhaps a little large. Could we use the newer download icon Fx is using on OS X? Eventually we want to switch all of our icons to something similar anyway.

Other than that, LGTM.

Comment 5

[Josiah Bruner [:jsbruner]]

Attachment: Comparison of Icons

Notice how the downloads icon seems to stick out more than the others.

Comment 6

[Richard Marti (:Paenglab)]

Attachment: aboutDownloadsStyles.patch

I've directly extracted the icon from FX's toolbar.png. Is this better?

We could also use the colored icon from http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/themes/osx/mozapps/downloads/downloadIcon.png. What do you think?

Comment 7

[Josiah Bruner [:jsbruner]]

It still looks wrong to me. Could we use the download icon from the yosemite icon set?

Comment 8

[Richard Marti (:Paenglab)]

Attachment: aboutDownloadsStyles.patch

Okay, now with the Yosemite icon.

Comment 9

[Josiah Bruner [:jsbruner]]

Comment on attachment 8577775 [details] [diff] [review]
aboutDownloadsStyles.patch

Review of attachment 8577775 [details] [diff] [review]:
-----------------------------------------------------------------

There we go. Just please include the HiDPI version of the icon as well and we'll be good to go.

Comment 10

[Richard Marti (:Paenglab)]

Hmm, I don't see how this can be done as the tab is of type="chromeTab" and I can't use a special style for this tab. And so the icon is defined through link rel="shortcut icon"... in aboutDownloads.xul.

Comment 11

[Richard Marti (:Paenglab)]

Attachment: aboutDownloadsStyles.patch

Approach using svg images to be resolution independent.

Comment 12

[Richard Marti (:Paenglab)]

Attachment: aboutDownloadsStyles.patch

Optimized the Windows svg a bit.

Comment 13

[Josiah Bruner [:jsbruner]]

Comment on attachment 8577971 [details] [diff] [review]
aboutDownloadsStyles.patch

Review of attachment 8577971 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent, thanks.

Comment 14

[Kent James (:rkent)]

Comment on attachment 8577971 [details] [diff] [review]
aboutDownloadsStyles.patch

Approval Request Comment
Consider after nightly

http://hg.mozilla.org/comm-central/rev/66ff5297b8cf

Comment 15

[Sylvestre Ledru [:Sylvestre]]

James, you requested the uplift to Firefox aurora itself?
Are you sure about that?

Comment 16

[Kent James (:rkent)]

Comment on attachment 8577971 [details] [diff] [review]
aboutDownloadsStyles.patch

I'm sorry, I keep hitting the m-c flags instead of the c-c flags.

Comment 17

[Kent James (:rkent)]

Comment on attachment 8577971 [details] [diff] [review]
aboutDownloadsStyles.patch

https://hg.mozilla.org/releases/comm-aurora/rev/0d49514e9ba2