1092559 - Searching for a contact name shows the surname multiple times in the result

Status: RESOLVED DUPLICATE of bug 1088706

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Pedro Cambra]

Attachment: Contact-search.jpg

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:36.0) Gecko/20100101 Firefox/36.0
Build ID: 20141031061804

Steps to reproduce:

* Create a contact 
* Search for the contact


Actual results:

The surname of the contact highlighted appears multiple times


Expected results:

No duplication should occur

Comment 1

[Pedro Cambra]

Working on this, no clue how to assign a bug to myself

Comment 2

[Pedro Cambra]

I'll keep digging into this but leaving my findings here, the issue apparently is with the highlight part of the shared search.js:

      newTerms.forEach(function replaceWithHighlight(term) {
        textNode.firstChild.innerHTML = textNode.textContent.replace(
          new RegExp('(' + term + ')', 'gi'),
          '<span class="' + highlightClass + '">$1</span>');
       });

This code, when the search is not ordered by last name (orderByLastName is false) produces a html output that repeats the last name as many times as number of chars introduced and besides, the original last name (not highlighted) remains there.

Comment 3

[Pedro Cambra]

I've seen a change without bug, not sure what's the context: "Search results highlighting does not work properly with special chars like accents" 5b59a3e and I think accents are still not highlighted, probably it's a separate bug, I'm pushing a fix for the duplication in this one.

Comment 4

[Pedro Cambra]

Attachment: Replace should not replace the first child only

Comment 5

[Phani]

Tested the patch attached to the ticket.

It does remove duplicate appends but it was missing the strong text in the contact name.

Here is a duplicate bug that has a similar fix without losing strong text

https://bugzilla.mozilla.org/show_bug.cgi?id=1092589

Comment 7

[Phani]

Hey Pedro,

Thanks for making me a collaborator to ur repo. I've pushed a fix to the branch "1092559_duplicate_name_search"

Kind regards,
Phani.

Comment 8

[Phani]

I've pushed a another commit that will avoid replacing html tags

    var text = "<strong>Chuck</strong> Norris"; 
    var term = "chuck"
    var highlightClass = "highlight"
    function addHighlightClass(p1, p2) {
        return ((p2 == undefined) || p2 == '') ? p1 : '<span class=' + highlightClass + '>' + p1 +     '</span>';
    }


    var term = "chuck"
    var result = text.replace(new RegExp('<[^>]+>|(' + term + ')', 'gi'), addHighlightClass);
    console.log(result);

    var term = "strong"
    var result = text.replace(new RegExp('<[^>]+>|(' + term + ')', 'gi'), addHighlightClass);
    console.log(result);

Kind regards,
Phani.

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8515596 [details] [review]
Replace should not replace the first child only

Just left a tiny comment, could you update the pull request.

Also could you squash all the commits in a single commit?

Comment 12

[Jose Manuel Cantera]

That is being fixed by bug 1088706