Open Bug 1092744 Opened 6 years ago Updated 3 months ago

Saving attachment file should use Downloads.jsm directly to make saved files items more informative

Categories

(MailNews Core :: Attachments, enhancement)

enhancement
Not set

Tracking

(Not tracked)

People

(Reporter: hiro, Unassigned)

References

Details

(Whiteboard: [patchlove])

Attachments

(1 file, 5 obsolete files)

Attached patch WIP v1 (obsolete) — Splinter Review
We can put more important information on the download manager view.
For example, sender of attachment file is one of the important information.

Attaching patch shows sender info in the view.
Attached patch WIP v2 (obsolete) — Splinter Review
Implemented MsgDownloads.saveAllAttachments.
Attachment #8515603 - Attachment is obsolete: true
Attached patch WIP v3 (obsolete) — Splinter Review
Used also Downloads.jsm on detaching.
Attachment #8517977 - Attachment is obsolete: true
Attached patch WIP v4 (obsolete) — Splinter Review
Added received date property for future reference.
Attachment #8518084 - Attachment is obsolete: true
Attached patch add MsgDownload.jsm and use it (obsolete) — Splinter Review
Attachment #8518109 - Attachment is obsolete: true
Whiteboard: [patchlove]
Patch unbitrotted and const changed to var.

Aceman, does this patch look complete as it is? I'm thinking of adding a reference to the message to jump to the message from download item and maybe also adding the subject. But this is something for a followup bug.
Attachment #8518772 - Attachment is obsolete: true
Attachment #8687689 - Flags: review?(acelists)
Comment on attachment 8687689 [details] [diff] [review]
MsgDownload_jsm.patch

I see now with this patch the saved attachments aren't shown in the list after a restart of TB (removing the patch and opening TB shows them again).
Attachment #8687689 - Flags: review?(acelists)
Does anybody know what this does? Is MsgDownloads.jsm some new code from m-c that migrates us more to the new downloads backend used in FF?
Flags: needinfo?(mconley)
Not sure. A brief glance doesn't suggest it's a migrator - looks more like mail-specific utility functions that wrap Downloads.jsm. Hiro can probably tell us for sure.
Flags: needinfo?(mconley) → needinfo?(hiikezoe)
Yes, Downloads.jsm has a capability which stores additional information.  Sender name is an example.
Other examples:

* sent date: it does not equal to saved date.
* message subject: if the subject is shown in download list, user can easily find the original message which contained the attachment file, or find other attachment files in the same message.
Flags: needinfo?(hiikezoe)
Summary: Saving attachment file should use Downloads.jsm directly → Saving attachment file should use Downloads.jsm directly to make saved files items more informative
You need to log in before you can comment on or make changes to this bug.