1092744 - Saving attachment file should use Downloads.jsm directly to make saved files items more informative

Status: NEW

(MailNews Core :: Attachments, enhancement)

Description

[Hiroyuki Ikezoe (:hiro)]

Attachment: WIP v1

We can put more important information on the download manager view.
For example, sender of attachment file is one of the important information.

Attaching patch shows sender info in the view.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: WIP v2

Implemented MsgDownloads.saveAllAttachments.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: WIP v3

Used also Downloads.jsm on detaching.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: WIP v4

Added received date property for future reference.

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Attachment: add MsgDownload.jsm and use it

Comment 5

[Richard Marti (:Paenglab)]

Attachment: MsgDownload_jsm.patch

Patch unbitrotted and const changed to var.

Aceman, does this patch look complete as it is? I'm thinking of adding a reference to the message to jump to the message from download item and maybe also adding the subject. But this is something for a followup bug.

Comment 6

[Richard Marti (:Paenglab)]

Comment on attachment 8687689 [details] [diff] [review]
MsgDownload_jsm.patch

I see now with this patch the saved attachments aren't shown in the list after a restart of TB (removing the patch and opening TB shows them again).

Comment 7

[:aceman]

Does anybody know what this does? Is MsgDownloads.jsm some new code from m-c that migrates us more to the new downloads backend used in FF?

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Not sure. A brief glance doesn't suggest it's a migrator - looks more like mail-specific utility functions that wrap Downloads.jsm. Hiro can probably tell us for sure.

Comment 9

[Hiroyuki Ikezoe (:hiro)]

Yes, Downloads.jsm has a capability which stores additional information.  Sender name is an example.
Other examples:

* sent date: it does not equal to saved date.
* message subject: if the subject is shown in download list, user can easily find the original message which contained the attachment file, or find other attachment files in the same message.