Closed Bug 1092814 Opened 10 years ago Closed 10 years ago

Intermittent day_observer_test.js | day_observer #on allday - expected { Object (amount, events, ...) } to deeply equal { Object (allday, events, ...) }

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect)

ARM
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S8 (7Nov)

People

(Reporter: philor, Assigned: mmedeiros)

References

Details

(Keywords: intermittent-failure, Whiteboard: time-bomb)

It's not going to be a coincidence that this started on the day when we switched away from Daylight Time.
Disabled for now for basically being a perma-fail, and I can't seem to find a clear regression-causing patch. I agree that this is likely due to DST, so we should disable the test instead of closing the tree.

Disabled: https://github.com/mozilla-b2g/gaia/commit/4ac0fb93e40bd1e65f813eb6f503f976065e9f3c

Gareth - I looked into this a bit and it appears that our calculations for determining what *is* and *isn't* an allday event is broken. I'm not sure if this is specifically because today is DST, but if the test passes tomorrow I guess that would be the case.
Flags: needinfo?(gaye)
Likely caused by bug 1074772.
Blocks: 1074772
We need to change the way we calculate "all day" events.. right now it only considers as an "all day" event if it starts at 00:00 and ends at 00:00 of a future date, and only if the ms difference between start-end is a round number of days (during DST change that isn't true, the day doesn't have 24h). I think the "all day" calculation should take into consideration a "base date".
Flags: needinfo?(gaye)
Depends on: 1093058
Assignee: nobody → mmedeiros
Target Milestone: --- → 2.1 S8 (7Nov)
Target Milestone: 2.1 S8 (7Nov) → 2.1 S9 (21Nov)
resolved by Bug 1093058 (re-enabled the test)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: 2.1 S9 (21Nov) → 2.1 S8 (7Nov)
You need to log in before you can comment on or make changes to this bug.