1092831 - BufferSourceNode using a BufferSource generated in code with two channels plays in mono

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Description

[Soledad Penades [:sole] [:spenades]]

http://sole.github.io/test_cases/web_audio/buffersourcenotstereo/

Expected: I would expect the sample to play in stereo - different sound in each channel

Results: The sample plays in mono (no spatial sense at all is perceived)

I get the expected result in Chrome.

Comment 1

[Paul Adenot (:padenot)]

Attachment: testcase

Sole, here is a simpler test case, and I can't seem to repro (I get noise on the left, sine on the right). Would you know what is different in your test case compared to mine ?

Comment 2

[Soledad Penades [:sole] [:spenades]]

Yes, I can confirm your test case works as expected. Let me investigate further to see what is the exact thing that causes this-I have a bunch of gain nodes and an analyser so maybe this is an error somewhere else :-o

Comment 3

[Soledad Penades [:sole] [:spenades]]

Attachment: updated test case that shows the issue

Comment 4

[Soledad Penades [:sole] [:spenades]]

Oh, I found it! it's the analyser node which is converting the inputs to mono output :O

Attaching updated test case.

Comment 5

[Paul Adenot (:padenot)]

Attachment: AnalyserNode should have channelCountMode set to "max". r=

https://github.com/WebAudio/web-audio-api/issues/450

Comment 6

[Paul Adenot (:padenot)]

Comment on attachment 8531005 [details] [diff] [review]
AnalyserNode should have channelCountMode set to "max". r=

Review of attachment 8531005 [details] [diff] [review]:
-----------------------------------------------------------------

Ehsan, this change make it so that AnalyserNode does not downmix its inputs to mono, and simply passes audio through, which is what authors expect.

The spec has been changed already [0].

[0]: https://github.com/WebAudio/web-audio-api/commit/201ed628acf82298688705f45c16e2649ec8495e

Comment 7

[(no longer active)]

Comment on attachment 8531005 [details] [diff] [review]
AnalyserNode should have channelCountMode set to "max". r=

Review of attachment 8531005 [details] [diff] [review]:
-----------------------------------------------------------------

I should have spotted this before...  Sorry!

Comment 8

[Paul Adenot (:padenot)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/de17f1dc109f

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/de17f1dc109f