[Stingray] Implement the config object

RESOLVED INVALID

Status

RESOLVED INVALID
4 years ago
4 years ago

People

(Reporter: yifan, Assigned: yifan)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
jj.evelyn
: review+
rexboy
: review+
Details | Review | Splinter Review
(Assignee)

Description

4 years ago
The config implemented for the TV browser should be designed as a javascript object which could be defined at build time according to a customizable JSON file. The build process will be discussed and align to the TV build process.
(Assignee)

Comment 1

4 years ago
Created attachment 8515771 [details] [review]
pull request

Defined a default config object. The config object will be generated at build time which will be implemented according to the customization process as discussed with John Hu and Rex.
Attachment #8515771 - Flags: review?(rexboy)
Attachment #8515771 - Flags: review?(ehung)
Comment on attachment 8515771 [details] [review]
pull request

Looks good to me. But I think it may be better to add some comment on file to denote that config.js would be generated at build time. (Although it's not implemented yet)
Attachment #8515771 - Flags: review?(rexboy) → review+
(Assignee)

Comment 3

4 years ago
Updated on Github. Please see if there's any question, thank you.

Updated

4 years ago
Attachment #8515771 - Flags: review?(ehung) → review+
(Assignee)

Comment 4

4 years ago
Canceled due to limited time frame.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.