1092911 - [Keyboard] mozL10n: A non-existing entity requested: alternateLayoutKey

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://github.com/mozilla-b2g/gaia/blob/master/apps/keyboard/js/keyboard/layout_manager.js#L210

Should be alternateLayoutKey2

and

https://github.com/mozilla-b2g/gaia/blob/master/apps/keyboard/js/keyboard/layout_manager.js#L221

Should be basicLayoutKey2

It was not caught until mozL10n gives runtime warning.

[Blocking Requested - why for this release]: Localization won't get picked up for these keys. Fortunately there is no string change for this bug.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

The code was moved by bug 1023730 in
https://github.com/mozilla-b2g/gaia/pull/21174/files

But it should be a regression of bug 1025633 since it should have changed the id in keyboard.js before bug 1023730.

Comment 2

[Mozilla Shepherd (This account is used for automation and doesn't receive bugmail)]

Attachment: mozilla-b2g:master PR#25742

Comment 3

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8515748 [details] [review]
mozilla-b2g:master PR#25742

r=me. Thanks.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I was 3 sec late before I realize this patch cause Gu breakage.

master: https://github.com/mozilla-b2g/gaia/commit/bb82b4dd49cfc0b42ca4a065844b5c4b0ec7694c
master revert: https://github.com/mozilla-b2g/gaia/commit/8aa66bc02e003c2fc9236e6cb6eb6c0415e8d349

Comment 5

[Mozilla Shepherd (This account is used for automation and doesn't receive bugmail)]

Attachment: mozilla-b2g:master PR#25753

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/9767c73451156c4f342922c4b6e9bd19ab8ba859

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8515811 [details] [review]
mozilla-b2g:master PR#25753

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1025633
[User impact] if declined: The screen reader will not be able to read out the switching keys
[Testing completed]: yes
[Risk to taking this patch] (and alternatives if risky): very little, actually just a two liner change.
[String changes made]: none

This bug need a branch specific patch. I will create the patch when we got this approved.

Comment 8

[bhavana bajaj [:bajaj]]

Comment on attachment 8515811 [details] [review]
mozilla-b2g:master PR#25753

Adding the NO_UPLIFT until we get a branch specific patch here. 

Tim, please remove that once the patch is ready.

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Branch patch is ready at
https://github.com/timdream/gaia/commit/1aeffedbec218ab37b7d93080f489ebf0314240f

Will merge when Gaia reopens.

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v2.1: https://github.com/mozilla-b2g/gaia/commit/1aeffedbec218ab37b7d93080f489ebf0314240f

Uplifted

Comment 11

[Yeojin Chung [:YeojinC]]

Unable to verify as it is a back-end issue.

Comment 12

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This is verifiable by turning on the screen reader. Although I have to admit I don't know how to use it myself.

Comment 13

[Yeojin Chung [:YeojinC]]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #12)
> This is verifiable by turning on the screen reader. Although I have to admit
> I don't know how to use it myself.

Hi Tim,
I was not sure what to look for to verify this bug. I can enable the screen reader via Developer menu. Could you provide some STRs to verify this after the screen reader is enabled? Thanks!

Comment 14

[Tim Guan-tin Chien [:timdream] (please needinfo)]

:eeejay should be able to help :)

Comment 15

[Eitan Isaacson [:eeejay]]

Verified.

You guys should really know how to test with the screen reader..
Basic operation is covered here:
https://wiki.mozilla.org/Accessibility/Mobile/ScreenReader

The STR:
1. Active screen reader.
2. Explore to homescreen search entry and double tap.
3. Explore Keyboard, bottom left button should say "more numbers and symbols button".

That's it!

Comment 16

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Eitan Isaacson [:eeejay] from comment #15)
> Verified.
> 
> You guys should really know how to test with the screen reader..
> Basic operation is covered here:
> https://wiki.mozilla.org/Accessibility/Mobile/ScreenReader
> 

Thanks! I am bookmarking this page.

Comment 17

[Sue]

Attachment: video of issue verify

This issue has been verified successfully on Flame 2.1
STR:
1. Active screen reader.
2. Explore to homescreen search entry and double tap.
3. Explore Keyboard, tap bottom left button "12&".
**It will say "more numbers and symbols button".
See attachment: verify_video.MP4
Reproducing rate: 0/5
Flame 2.1 versions:
Gaia-Rev        8ae086c39011bc8842b2a19bb5267906fa22345a
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/ebbd5c65c3c1
Build-ID        20141124094013
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141124.130744
FW-Date         Mon Nov 24 13:07:55 EST 2014
Bootloader      L1TC00011880