Closed Bug 1092939 Opened 5 years ago Closed 5 years ago

OS X 10.10: disabled back button has an :active sate

Categories

(Firefox :: Theme, defect)

x86_64
All
defect
Not set
Points:
1

Tracking

()

RESOLVED FIXED
Firefox 42
Tracking Status
firefox39 --- wontfix
firefox40 --- fixed
firefox41 --- fixed
firefox42 --- fixed

People

(Reporter: paul, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Yosemite @2x.

When the back button is disabled, clicking on it changes its background.

Wondering if it's new thing (it wasn't like that before), or a regression of bug 1053434.
I can't reproduce on non-yosemite, so I actually expect I messed something up in the yosemite styling...
Yeah, this reproduces on the oct. 20th nightly as well, so I expect this is all my own fault. :-(
Points: --- → 1
Flags: qe-verify-
Flags: in-testsuite-
Flags: firefox-backlog+
Summary: (regression?) osx: disabled back button has an :active sate → OS X 10.10: disabled back button has an :active sate
Actually, I can't figure out why this isn't broken on pre-10.10; the selectors there don't check for [disabled]...
See Also: → 1090403
Duplicate of this bug: 1090403
Duplicate of this bug: 1178113
Flags: needinfo?(gijskruitbosch+bugs)
(In reply to :Gijs Kruitbosch from comment #3)
> Actually, I can't figure out why this isn't broken on pre-10.10; the
> selectors there don't check for [disabled]...

Uh...

#back-button:not([disabled="true"]):active:hover:not(:-moz-lwtheme),

http://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/browser.css#1231
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(gijskruitbosch+bugs)
Bug 1092939 - fix disabled back button active state, r?ttaubert
Attachment #8629994 - Flags: review?(ttaubert)
I can't test this fix easily myself because of bug 1180688, but I think this should work. Tim, can you verify?
Comment on attachment 8629994 [details]
MozReview Request: Bug 1092939 - fix disabled back button active state, r?ttaubert

https://reviewboard.mozilla.org/r/12661/#review11139

Confirmed that it works on 10.10.
Attachment #8629994 - Flags: review?(ttaubert) → review+
Shouldn't need a trypush, is just a tiny CSS fix.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f62e38329044
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Comment on attachment 8629994 [details]
MozReview Request: Bug 1092939 - fix disabled back button active state, r?ttaubert

Approval Request Comment
[Feature/regressing bug #]: yosemite-specific CSS work
[User impact if declined]: you can click the back button on OSX yosemite and it'll look as if it's doing something even when it's disabled
[Describe test coverage new/current, TreeHerder]: nope
[Risks and why]: pretty much none, CSS-only change
[String/UUID change made/needed]: nope
Attachment #8629994 - Flags: approval-mozilla-beta?
Attachment #8629994 - Flags: approval-mozilla-aurora?
Comment on attachment 8629994 [details]
MozReview Request: Bug 1092939 - fix disabled back button active state, r?ttaubert

Trivial but noticeable functional correctness fix. Beta+ Aurora+
Attachment #8629994 - Flags: approval-mozilla-beta?
Attachment #8629994 - Flags: approval-mozilla-beta+
Attachment #8629994 - Flags: approval-mozilla-aurora?
Attachment #8629994 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.