Closed
Bug 1092939
Opened 10 years ago
Closed 9 years ago
OS X 10.10: disabled back button has an :active sate
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 42
People
(Reporter: paul, Assigned: Gijs)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
40 bytes,
text/x-review-board-request
|
ttaubert
:
review+
lmandel
:
approval-mozilla-aurora+
lmandel
:
approval-mozilla-beta+
|
Details |
Yosemite @2x. When the back button is disabled, clicking on it changes its background. Wondering if it's new thing (it wasn't like that before), or a regression of bug 1053434.
Assignee | ||
Comment 1•10 years ago
|
||
I can't reproduce on non-yosemite, so I actually expect I messed something up in the yosemite styling...
Assignee | ||
Comment 2•10 years ago
|
||
Yeah, this reproduces on the oct. 20th nightly as well, so I expect this is all my own fault. :-(
Blocks: theme-yosemite
Points: --- → 1
Flags: qe-verify-
Flags: in-testsuite-
Flags: firefox-backlog+
Summary: (regression?) osx: disabled back button has an :active sate → OS X 10.10: disabled back button has an :active sate
Assignee | ||
Comment 3•10 years ago
|
||
Actually, I can't figure out why this isn't broken on pre-10.10; the selectors there don't check for [disabled]...
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(gijskruitbosch+bugs)
Assignee | ||
Comment 6•9 years ago
|
||
(In reply to :Gijs Kruitbosch from comment #3) > Actually, I can't figure out why this isn't broken on pre-10.10; the > selectors there don't check for [disabled]... Uh... #back-button:not([disabled="true"]):active:hover:not(:-moz-lwtheme), http://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/browser.css#1231
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(gijskruitbosch+bugs)
Assignee | ||
Comment 7•9 years ago
|
||
Bug 1092939 - fix disabled back button active state, r?ttaubert
Attachment #8629994 -
Flags: review?(ttaubert)
Assignee | ||
Comment 8•9 years ago
|
||
I can't test this fix easily myself because of bug 1180688, but I think this should work. Tim, can you verify?
Comment 9•9 years ago
|
||
Comment on attachment 8629994 [details] MozReview Request: Bug 1092939 - fix disabled back button active state, r?ttaubert https://reviewboard.mozilla.org/r/12661/#review11139 Confirmed that it works on 10.10.
Attachment #8629994 -
Flags: review?(ttaubert) → review+
Assignee | ||
Comment 10•9 years ago
|
||
Shouldn't need a trypush, is just a tiny CSS fix.
Keywords: checkin-needed
Comment 11•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/f62e38329044
Keywords: checkin-needed
Comment 12•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f62e38329044
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Assignee | ||
Comment 13•9 years ago
|
||
Comment on attachment 8629994 [details] MozReview Request: Bug 1092939 - fix disabled back button active state, r?ttaubert Approval Request Comment [Feature/regressing bug #]: yosemite-specific CSS work [User impact if declined]: you can click the back button on OSX yosemite and it'll look as if it's doing something even when it's disabled [Describe test coverage new/current, TreeHerder]: nope [Risks and why]: pretty much none, CSS-only change [String/UUID change made/needed]: nope
Attachment #8629994 -
Flags: approval-mozilla-beta?
Attachment #8629994 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
Comment 14•9 years ago
|
||
Comment on attachment 8629994 [details] MozReview Request: Bug 1092939 - fix disabled back button active state, r?ttaubert Trivial but noticeable functional correctness fix. Beta+ Aurora+
Attachment #8629994 -
Flags: approval-mozilla-beta?
Attachment #8629994 -
Flags: approval-mozilla-beta+
Attachment #8629994 -
Flags: approval-mozilla-aurora?
Attachment #8629994 -
Flags: approval-mozilla-aurora+
You need to log in
before you can comment on or make changes to this bug.
Description
•