FTE to follow text selection pattern

VERIFIED FIXED in Firefox OS v2.2

Status

Firefox OS
Gaia::First Time Experience
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: howie, Assigned: sfoster)

Tracking

unspecified
2.2 S2 (19dec)
x86
Mac OS X
Dependency tree / graph

Firefox Tracking Flags

(feature-b2g:2.2+, b2g-v2.2 verified)

Details

(Whiteboard: [systemsfe])

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

3 years ago
Created attachment 8515827 [details]
FxOS 2.2 Text Selection Guidelines 03.pdf

* Input fields (input areas, input dialogs and search fields) are the only Building Blocks with selectable text. 

* HTML elements like buttons or links, or events like ontouchstart or onclick, should trigger the action when tapped rather than triggering text selection.
(Reporter)

Comment 1

3 years ago
The Gecko work is close to completion, the remaining part is to fix test case failures then pref it on in m-c bug 1092888. After the bug landed, text selection and cut/copy/paste can be triggered in apps on both editable and non-editable elements.

Gaia per app work in v2.2 is to follow UX guideline and leverage CSS -moz-user-select https://developer.mozilla.org/en-US/docs/Web/CSS/user-select to make certain elements non-selectable.

Before Gecko is pref on in m-c, Gaia can manually switch it on by the following two pref to test in advance:
pref("selectioncaret.enabled", on);
pref("selectioncaret.noneditable", on);
(Assignee)

Comment 2

3 years ago
In principle there should be 0 (code) work to do here as far as I understand it: https://github.com/mozilla-b2g/gaia/blob/master/apps/ftu/style/style.css#L9 has the -moz-user-select rule and with some cursory testing just now I'm getting the expected results. We'll need a pretty thorough QA run though to confirm. Lets discuss when that should happen because we have a fairly large patch in the wings (bug 1067462) that touches a lot of markup and CSS and I would hate to cause double the testing work.
(Reporter)

Comment 3

3 years ago
This is a 2.2 feature.
feature-b2g: 2.2? → 2.2+
Whiteboard: [systemsfe]
Assignee: nobody → sfoster

Comment 4

3 years ago
Created attachment 8537998 [details] [review]
[PullReq] sfoster:ftu-selection-patterns-bug-1092965 to mozilla-b2g:master
(Assignee)

Comment 5

3 years ago
Created attachment 8537999 [details] [review]
PR: Disable text selection for non-editables in FTU

Following system app's lead, disable text selection for all but the explicitly editable elements. I tested without the patch (we get selection and copy/paste menu for all text in FTU) and with the patch (only editable fields are selectable). 

Not sure if there's value in automated tests for this - it would be difficult to write a reliable UI test and its quick to check manually.
Attachment #8537999 - Flags: review?(fernando.campo)
(Assignee)

Updated

3 years ago
Attachment #8537999 - Attachment is obsolete: true
Attachment #8537999 - Flags: review?(fernando.campo)
(Assignee)

Comment 6

3 years ago
Comment on attachment 8537998 [details] [review]
[PullReq] sfoster:ftu-selection-patterns-bug-1092965 to mozilla-b2g:master

Still getting used to autolander, sorry for noise
Attachment #8537998 - Flags: review?(fernando.campo)
Comment on attachment 8537998 [details] [review]
[PullReq] sfoster:ftu-selection-patterns-bug-1092965 to mozilla-b2g:master

Works great, thanks.
Attachment #8537998 - Flags: review?(fernando.campo) → review+
(Assignee)

Comment 8

3 years ago
thanks fcampo. Autolander, you can take it from here I hope!
Keywords: checkin-needed

Updated

3 years ago
Keywords: checkin-needed

Comment 9

3 years ago
There was an error creating the taskgraph, please try again. If the issue persists please contact someone in #taskcluster.
(Assignee)

Comment 10

3 years ago
Merged to master: https://github.com/mozilla-b2g/gaia/commit/192bb2ac26cac23ac2b49caad17517f0be68c13f
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S2 (19dec)

Updated

3 years ago
Depends on: 1131838

Updated

3 years ago
Depends on: 1131852
This issue is cannot be verified fixed on Flame 3.0 due to bugs 1131838, 1131852 being open. I will try to verify this bug again once the dependencies have been resolved.
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(pbylenga)
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(pbylenga)
Keywords: verifyme

Updated

3 years ago
No longer depends on: 1131838
Created attachment 8569675 [details]
screenshot.PNG

This issue has been verified successfully on Flame v2.2, user is able to select text in input fields (input areas, input dialogs and search fields) and allowing them cut/copy/paste.
See attachment:screenshot.png
Rate:0/5

Flame 2.2 build:
Build ID               20150225002505
Gaia Revision          ca64f2fe145909f31af266b1730874051ba76c78
Gaia Date              2015-02-24 22:06:53
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/16804008c29f
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150225.041814
Firmware Date          Wed Feb 25 04:18:25 EST 2015
Bootloader             L1TC000118D0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage+][MGSEI-Triage+]
status-b2g-v2.2: --- → verified
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.