Gallery app to follow text selection pattern

RESOLVED FIXED in 2.2 S2 (19dec)

Status

Firefox OS
Gaia::Gallery
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: howie, Assigned: pdahiya)

Tracking

unspecified
2.2 S2 (19dec)
x86
Mac OS X
Dependency tree / graph

Firefox Tracking Flags

(feature-b2g:2.2+)

Details

Attachments

(2 attachments)

(Reporter)

Description

4 years ago
Created attachment 8515830 [details]
FxOS 2.2 Text Selection Guidelines 03.pdf

* Input fields (input areas, input dialogs and search fields) are the only Building Blocks with selectable text. 

* HTML elements like buttons or links, or events like ontouchstart or onclick, should trigger the action when tapped rather than triggering text selection.
(Reporter)

Comment 1

4 years ago
The Gecko work is close to completion, the remaining part is to fix test case failures then pref it on in m-c bug 1092888. After the bug landed, text selection and cut/copy/paste can be triggered in apps on both editable and non-editable elements.

Gaia per app work in v2.2 is to follow UX guideline and leverage CSS -moz-user-select https://developer.mozilla.org/en-US/docs/Web/CSS/user-select to make certain elements non-selectable.

Before Gecko is pref on in m-c, Gaia can manually switch it on by the following two pref to test in advance:
pref("selectioncaret.enabled", on);
pref("selectioncaret.noneditable", on);

Updated

4 years ago
Blocks: 1095707
(Reporter)

Comment 2

4 years ago
This is a 2.2 feature.
feature-b2g: 2.2? → 2.2+

Updated

4 years ago
Assignee: nobody → dflanagan

Updated

4 years ago
QA Whiteboard: [2.2-feature-qa+]
(Assignee)

Updated

4 years ago
Assignee: dflanagan → pdahiya
(Assignee)

Comment 3

4 years ago
Taking the bug to implement text selection as per attached guidelines for gallery app.
(Assignee)

Comment 4

4 years ago
Created attachment 8535797 [details] [review]
Patch with fix of Bug 1092967

Hi David
As per attached text selection guidelines, submitting patch so that gallery app by default should not have any selectable text. Please review. Thanks!
Attachment #8535797 - Flags: review?(dflanagan)
Comment on attachment 8535797 [details] [review]
Patch with fix of Bug 1092967

r+, but talk to Russ before landing. In his bug for the video app, he's putting -moz-user-select:none on each absolutely positioned element rather than using the * wildcard. I'm okay with both approaches, but the two of you might want to consider using the same approach in both apps.

I updated https://developer.mozilla.org/en-US/docs/Web/CSS/user-select to point out that this property is not inherited by absolutely positioned elements in Firefox.
Attachment #8535797 - Flags: review?(dflanagan) → review+

Updated

4 years ago
Target Milestone: --- → 2.2 S2 (19dec)
(Assignee)

Comment 6

4 years ago
Synched up with Russ to go ahead with approach used in attached PR for both gallery and video app. Patch landed on master.

https://github.com/mozilla-b2g/gaia/commit/8ffb48c321bb9595ad437086c5eb450bc90aa714
(Assignee)

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.