1093011 - Entering single $ sign yields autocorrect suggestions

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Jan Jongboom [:janjongboom] (inactive)]

Type single $
Expected: no autocorrect
Result: autocorrect gives 'A*', 'As', 'At'.

Comment 1

[Jan Jongboom [:janjongboom] (inactive)]

Attachment: Patch

Trivial patch

Comment 2

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8515895 [details] [diff] [review]
Patch

Thanks.

Comment 3

[Jan Jongboom [:janjongboom] (inactive)]

https://github.com/mozilla-b2g/gaia/commit/6a58db08871a7e8dd367ee850a9067ecc8e5637d

Comment 5

[Daniel Holbert [:dholbert]]

Firefox OS 2.1 is still affected by this -- I've run into this bug several times while dogfooding 2.1 on my Flame. (This bug makes a text message like "Bring $ for food" get autocorrected to "Bring A for food")

If you think it's appropriate, could you request approval to backport this to 2.1? Given that the patch is trivial, I'd hope it would be safe to backport.

Comment 6

[Daniel Holbert [:dholbert]]

(Also, FWIW: it looks like dev_apps/demo-keyboard/js/predictions.js still has a "$" in its version of this rootToAccentedForm map:
https://github.com/mozilla-b2g/gaia/blob/master/dev_apps/demo-keyboard/js/predictions.js#L223
Not sure if that's used anywhere or maintained, though.)

Comment 7

[Jan Jongboom [:janjongboom] (inactive)]

demo-keyboard is not used. 

But on this issue let's ni Rudy to see what he thinks.

Comment 8

[Daniel Holbert [:dholbert]]

Ah, thanks!

I think you might've missed this other question, before that one:
> If you think it's appropriate, could you request approval to backport this to 2.1?

Adding back ni=janjongboom for that. (I'm hoping this can be fixed on my Flame w/ FxOS 2.1 on it.)

Comment 9

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

For this issue to going into v2.1, we need to nominate this by marking blocking-2.1?
You could try to nominate, though IMHO this won't block the release.

Thanks.

Comment 10

[Daniel Holbert [:dholbert]]

Comment on attachment 8515895 [details] [diff] [review]
Patch

I agree that it doesn't make sense for this to block the release, but I also think we should take this patch, because it's trivial (extremely low-risk) and it fixes an annoying papercut.  Hence, requesting approval (on janjongboom's behalf, after brief chat w/ him & fabrice in #b2g).

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Unknown (looks like "$" has been in this list since forever)*

[User impact] if declined: "$" gets autocorrected, so you can't use "$" as a shorthand for "money", as in "Bring $ for food"

[Testing completed]: Patch has landed on Firefox OS 2.2 already. I've verified that the bug doesn't happen there.

[Risk to taking this patch] (and alternatives if risky): Extremely low-risk. Just removes "$" from the list of characters that we interpret as an "s" for autocorrection-purposes.

[String changes made]: None.


* (I did a little git-blame-digging, and it looks like "$" has been in the list for "s" here since at least https://github.com/mozilla-b2g/gaia/commit/6673f59c731bd0102fcbd933ff559128b78a62e7#diff-e33a13f125ddfeffcfca86396c71589cR35 in 2012 )

Comment 11

[bhavana bajaj [:bajaj]]

Comment on attachment 8515895 [details] [diff] [review]
Patch

Keeping the extreme low risk on the patch and https://bugzilla.mozilla.org/show_bug.cgi?id=1093011#c5 in mind which helps us tell that dogfooding/regular users will hit this when using auto correction, I am approving this.

If there are any fallouts due to this we can back this out immediately, but :dholbert asserted we should be fine ;)

Comment 12

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/2055fc40a8bd2af1908979cb45da6b7d1c4ced0b

Comment 13

[Shally Li（leave from Mozilla）]

This bug has been successfully verified on Flame v2.1&2.2.
See attachment: verified_v2.1&2.2.png.
Reproduce rate: 0/5.

Flame 2.1 build:
Gaia-Rev        2055fc40a8bd2af1908979cb45da6b7d1c4ced0b
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/38ac70ca969b
Build-ID        20150122001404
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150122.034705
FW-Date         Thu Jan 22 03:47:16 EST 2015
Bootloader      L1TC000118D0

Flame 2.2 build:
Gaia-Rev        e4f9b5da3751798f9cc5d95f302c30722cc11fca
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/4a90da67661e
Build-ID        20150122002808
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150122.041326
FW-Date         Thu Jan 22 04:13:37 EST 2015
Bootloader      L1TC000118D0

Comment 14

[Shally Li（leave from Mozilla）]

Attachment: verified_v2.1&2.2.png

Comment 15

[Jan Jongboom [:janjongboom] (inactive)]

This bug caused bug 1127776. Which is a minor issue.

Comment 16

[Julien Wajsberg [:julienw]]

(In reply to Jan Jongboom [:janjongboom] (Telenor) from comment #15)
> This bug caused bug 1127776. Which is a minor issue.

Not that minor, I get this several times a day, this is really painful.