1093025 - Support separate listen and stream sockets for low-level I/O

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Currently, the code around |UnixSocketConsumer| allows to listen for connection requests. When accepting the request, the I/O code closes the listen socket.

This behavior leads to race conditions in the connect/disconnect prodecure. We should have support for separate listen and stream sockets.

Comment 1

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: (Gaia Test Patch) Certificate test app

Apply patch to gaia, build, then flash, a "Certificate Test" app should appear in home screen.

"Import Certificates" will import a test certificate and ready to be read by keystore.
"Delete Certificates" will delete the imported certificate.
"Certificate List" will show full name of certificate used for keystore read command.

Use "adb shell keystore_cli g WIFI_SERVERCERT_ServerCert" to read certificate from keystore socket, the expected result should be:
-----BEGIN CERTIFICATE-----
MIICrjCCAhegAwIBAgIJAJJJ4mJx9seSMA0GCSqGSIb3DQEBBQUAMHAxCzAJBgNV
BAYTAlRXMQ8wDQYDVQQIDAZUYWlwZWkxEDAOBgNVBAoMB01vemlsbGExCzAJBgNV
BAsMAlFBMQ4wDAYDVQQDDAVHZXJyeTEhMB8GCSqGSIb3DQEJARYSZ2NoYW5nQG1v
emlsbGEuY29tMB4XDTE0MDUyMzA5NDIzN1oXDTE3MDUyMjA5NDIzN1owcDELMAkG
A1UEBhMCVFcxDzANBgNVBAgMBlRhaXBlaTEQMA4GA1UECgwHTW96aWxsYTELMAkG
A1UECwwCUUExDjAMBgNVBAMMBUdlcnJ5MSEwHwYJKoZIhvcNAQkBFhJnY2hhbmdA
bW96aWxsYS5jb20wgZ8wDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBANPbVMzKC+75
ijcNBosgAEpVhJAat5yRsjhrizJ6iZ55cYhDIZQYqPzjeoqzofcj5xrj5w3xZiFY
IYVbNexo0v1EdpMFu4l9kvnOdaPrOcF9flD5uGBh9y9UOf6KILINSH8YDQLMe44x
6b78li5jb/pMxM+K5BNn8ew+2COhv2dxAgMBAAGjUDBOMB0GA1UdDgQWBBQT4ayk
dT0sX+VBQpBaSFxGvCSOoTAfBgNVHSMEGDAWgBQT4aykdT0sX+VBQpBaSFxGvCSO
oTAMBgNVHRMEBTADAQH/MA0GCSqGSIb3DQEBBQUAA4GBAKprYlN0KiB2q9JgBv2I
9RyF5lfx8BiXfHC4tHzMWI30fLY0zBV5r3WpC9Hq+IV86BnpE5CEXyGUCk0V79EW
1LosWRuDI/Wlzb3aMnNGSZjz+1BuMNc+MdboZS9a8Q97CiFhjkUpT3oE2in8b8Ve
7uEP1Uu3yWqOfBnvbmSY/uM1
-----END CERTIFICATE-----

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 1093025: Initialize listen socket only once in |UnixSocketWatcher::Listen|

Comment 3

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [02] Bug 1093025: Move |UnixSocketConnector| to separate file

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [03] Bug 1093025: Add |ListenSocket|

Comment 5

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [04] Bug 1093025: Add |StreamSocket|

Comment 6

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Shawn,

it seems like Kyle is away for the rest of the month. Would you have time to review these I/O patches?

Comment 7

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

I would like to help but it's better to ask IPC module owner :bent is a better choice.

Comment 8

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Ben, do you have time to review this patch set?

Comment 9

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Hi Thomas, unfortunately no, I'm pretty swamped at the moment :(

Comment 10

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

OMFG you had to wait for me to get back from a 2 month vacation for this to get reviewed? D:

Well, anyways, I'm back. Does this need to be rebased before I start reviewing since it's been almost a month ( D: D: D: ), or can I get started now?

Comment 11

[Thomas Zimmermann [:tzimmermann] [:tdz]]

(In reply to Kyle Machulis (OUT OCT 1-NOV 30) [:kmachulis] [:qdot] (USE NEEDINFO?) from comment #10)
> OMFG you had to wait for me to get back from a 2 month vacation for this to
> get reviewed? D:

Don't worry. :) Right, it's only required for fixing some test cases.

> Well, anyways, I'm back. Does this need to be rebased before I start
> reviewing since it's been almost a month ( D: D: D: ), or can I get started
> now?

Just tested and the patch set applied cleanly.

Comment 12

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Thanks a lot, Kyle!

https://hg.mozilla.org/integration/b2g-inbound/rev/886723fddcd1
https://hg.mozilla.org/integration/b2g-inbound/rev/62f3c073833a
https://hg.mozilla.org/integration/b2g-inbound/rev/1840df9fd190
https://hg.mozilla.org/integration/b2g-inbound/rev/73e1dda14ec9

https://treeherder.mozilla.org/ui/#/jobs?repo=b2g-inbound&revision=73e1dda14ec9

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/886723fddcd1
https://hg.mozilla.org/mozilla-central/rev/62f3c073833a
https://hg.mozilla.org/mozilla-central/rev/1840df9fd190
https://hg.mozilla.org/mozilla-central/rev/73e1dda14ec9