Closed Bug 1093056 Opened 6 years ago Closed 6 years ago

Scrollbars shown in room list when there are no rooms

Categories

(Hello (Loop) :: Client, defect, P1)

Product:
Hello (Loop)
Component:
Client
Type:
defect

Tracking

(firefox35 fixed, firefox36 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla36
Iteration:
36.2
Tracking Flags:
Tracking Status
firefox35 --- fixed
firefox36 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Whiteboard: [good first verify])

Attachments

(2 files)

Screenshot of empty scrollbars
13.78 KB, image/png
Details
Scrollbars shouldn't be shown in the room list by default.
762 bytes, patch
NiKo
: review+
lsblakk
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
When I have no rooms in the list, I get a strange box with a couple of empty scrollbars in it.

This looks strange - see the attached image.
Simple fix to stop scrollbars being shown permanently.
Attachment #8516597 - Flags: review?(nperriault)
Assignee: nobody → standard8
Iteration: --- → 36.2
Priority: -- → P1
Comment on attachment 8516597 [details] [diff] [review]
Scrollbars shouldn't be shown in the room list by default.

Review of attachment 8516597 [details] [diff] [review]:
-----------------------------------------------------------------

Make sense!
Attachment #8516597 - Flags: review?(nperriault) → review+
https://hg.mozilla.org/integration/fx-team/rev/d64ba06f8472
Target Milestone: --- → mozilla36
status-firefox36: --- → fixed
Flags: qe-verify-
Flags: in-testsuite?
Flags: in-moztrap-
Whiteboard: [good first verify]
status-firefox35: --- → fixed
Comment on attachment 8516597 [details] [diff] [review]
Scrollbars shouldn't be shown in the room list by default.

Approval Request Comment
Landed on aurora per IRC with lsblakk with a=loop-only
Attachment #8516597 - Flags: approval-mozilla-aurora?
Attachment #8516597 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
css-only change, so I'm not sure this is worth looking at testsuite for. This was just a simple mistake that's easily noticeable visibly.
Flags: in-testsuite? → in-testsuite-
You need to log in before you can comment on or make changes to this bug.