1093058 - [Calendar] update the way all day events are calculated

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Miller Medeiros [:millermedeiros]]

We need to change the way we calculate "all day" events.. right now it only considers as an "all day" event if it starts at 00:00 and ends at 00:00 of a future date, and only if the ms difference between start-end is a round number of days (during DST change that isn't true, the day doesn't have 24h). I think the "all day" calculation should take into consideration a "base date".

Steps to reproduce:

 - create an event that spans thru multiple days;
 - check MonthsDay, Week and Day views;

Expected: Event that started before 00:00 of selected day and ends after 23:59 should be listed as "all day" event.

Actual: Event is displayed together with regular events.

Comment 1

[Miller Medeiros [:millermedeiros]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25781

Comment 2

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8516254 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25781

A couple questions on GH but mostly looks great. Thanks for updating test cases also :)

Comment 3

[Miller Medeiros [:millermedeiros]]

landed on master: https://github.com/mozilla-b2g/gaia/commit/d02e2bba29f08bd7d97f57ccc2aea23353a1d8be