Closed
Bug 1093074
Opened 10 years ago
Closed 10 years ago
Fix the search telemetry histograms description
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 36
People
(Reporter: gfritzsche, Assigned: gfritzsche)
References
Details
Attachments
(1 file)
|
1.07 KB,
patch
|
bwinton
:
review+
|
Details | Diff | Splinter Review |
We mirrored the most current FHR search providers approach here, which isn't limited to recording partner engines anymore.
Attachment #8515974 -
Flags: review?(bwinton)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8515974 [details] [diff] [review] Fix description Review of attachment 8515974 [details] [diff] [review]: ----------------------------------------------------------------- Yep. r=me, preferably with the nit fixed. ;) ::: toolkit/components/telemetry/Histograms.json @@ +4496,5 @@ > "SEARCH_COUNTS": { > "expires_in_version": "never", > "kind": "count", > "keyed": true, > + "description": "Record the search counts for search engines" Nit: The sentence should end in a "." (like the one below).
Attachment #8515974 -
Flags: review?(bwinton) → review+
|
Assignee | |
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ab982673790e
https://hg.mozilla.org/mozilla-central/rev/ab982673790e
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
You need to log in
before you can comment on or make changes to this bug.
Description
•