109318 - Ctrl+click in select list sometimes causes another selection to be cleared

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Steve Chapel]

Reproducible: Sometimes

Steps to reproduce:
1. Go to http://bugzilla.mozilla.org/query.cgi
2. Ctrl+click (Apple+Click on Mac) on in the Severity select box in the order:
blocker, critical, major.
3. Continue clicking in this order until Ctrl+clicking on one item causes
another item to be deselected.

Expected results: Ctrl-clicking a select item causes only that item to be
selected or deselected.

Actual results: Ctrl-clicking a select item causes two items to be selected or
deselected.

I first noticed this on Windows build 2001110803, but can also reproduce on
Windows build 2001110903 and Mac build 2001110804.

Comment 1

[Alexandru Savulov]

--> not submission

Comment 2

[Jesse Ruderman]

*** Bug 109386 has been marked as a duplicate of this bug. ***

Comment 3

[Steve Chapel]

Fixing Summary (misspelled Ctrl). I can't reproduce this in build 2001110603.

Comment 4

[scalkins]

I see this in todays trunk win32  2001-11-14-10 Trunk
Is this the right component/owner?

Comment 5

[sairuh (rarely reading bugmail)]

this is a recent regression.

bryner/saari, any ideas what might've caused this?

pls reassign this as needed, thx!

Comment 6

[Brian Ryner (not reading)]

this sounds like an html select bug... cc'ing rods and jkeiser.  any ideas, guys?

Comment 7

[John Keiser (jkeiser)]

Could it be that you are ctrl+click+dragging?  If you ctrl+click on one element
and your pointer moves into the next, it will be just like you did a normal
click+drag.  There is another bug out there (I think) on ctrl+drag, but I can
produce a patch pretty easily if this is what people want.

I am not seeing anything out of the ordinary here.

Comment 8

[John Keiser (jkeiser)]

The bug I'm referring to is bug 40983.  I'm putting up a patch for it soon.

Comment 9

[John Keiser (jkeiser)]

OK, actually I just realized that's a silly theory.  But I am not seeing this on
Linux as of yesterday.

Comment 10

[Steve Chapel]

> Could it be that you are ctrl+click+dragging?

Yes, if I very slowly and carefully ctrl+click so that I don't move the mouse at
all, I can't reproduce this bug. But if I move the mouse even one pixel, that's
considered a ctrl+click+drag instead of a ctrl+click. It seems like the drag
threshhold decreased recently, because I never used to have this problem with
ctrl+click, and now I have to slow way down to ctrl+click correctly.

Comment 11

[John Keiser (jkeiser)]

Hmm.  I wasn't aware that it was actually a problem before, but I fixed the drag
threshold in the patch I just attached to bug 40983, let's see if that fixes the
problem.  Now the threshold will be, drag does not have any new effect until you
put your mouse over a new option.

Comment 12

[Olivier Cahagne]

*** Bug 111923 has been marked as a duplicate of this bug. ***

Comment 13

[rods (gone)]

reassigning

Comment 14

[Asa Dotzler [:asa]]

jkeiser, sometime recently this bacame a problem. I'm not sure if it was in any
your changes to form controls or not. Right now I am unable to use bugzilla for
many of my regular queries. Is that patch at bug 40983 likely to land any time
soon? If not can you make a patch for just the bits that adjust the drag
threshhold for this bug. To see the problem I'm talking about try to ctrl click
select 10 items in the Components select at query.cgi. No matter how careful I
am I can never get more than about 6 or 7 items selected before one of my ctrl
clicks is treated like a regular click (or a click drag) and my selection is
lost. This is dogfood for me in using Bugzilla. 

Comment 15

[John Keiser (jkeiser)]

Sure.  I'll make up a new patch for bug 40983 soon, and if *that* one isn't
accepted I'll just do the partial patch for this one.

Comment 16

[Paul Baker]

This is happening in build 2001112903 on Windows 2000. Selecting in multi-select
boxes is totally hosed. Ctrl+clicking on a new item in a multi-select unselects
all previously selected items. Ctrl+clicking on a already selected item does not
remove the selection like it should.

Comment 17

[Asa Dotzler [:asa]]

ctrl+click does deselect selected items for me with 113003. If that's not
working please file another bug. 

Comment 18

[John Keiser (jkeiser)]

See your comments as of the 26th :)  I am still seeing the drag threshold
problem: i.e. if you ctrl+DRAG within an option then it treats your selection
like a normal drag.  Drag is reported by MouseMove currently, and that's rather
likely.

The fix for that problem is contained in the patch for one bug and will soon be
contained in another.

Comment 19

[TucsonTester3]

Attachment: Html simplified

after removing all extra text the problem is still there.
<html> <tbody>
</td> <td align="Left" valign="Top"> <select name="bug_status" multiple=""
size="7">
<option value="UNCONFIRMED">UNCONFIRMED</option>
<option selected="" value="NEW">NEW </option>
<option selected="" value="ASSIGNED">ASSIGNED </option>
<option selected="" value="REOPENED">REOPENED </option>
<option value="RESOLVED">RESOLVED</option>
<option value="VERIFIED">VERIFIED</option>
<option value="CLOSED">CLOSED</option>
</select>

Comment 20

[Madhur Bhatia]

*** Bug 113245 has been marked as a duplicate of this bug. ***

Comment 21

[Olivier Cahagne]

*** Bug 117454 has been marked as a duplicate of this bug. ***

Comment 22

[John Keiser (jkeiser)]

Could you retest with tomorrow's build (or CVS?).  bug 40983 has gone in and has
a fix that I suspect fixes your problem.

Comment 23

[John Keiser (jkeiser)]

This looks like it's fixed.  Reopen if you still have problems.

Comment 24

[Asa Dotzler [:asa]]

My complaint has been fixed. It seems to work as expected for me. Thanks.

Comment 25

[xyzzy]

*** Bug 120636 has been marked as a duplicate of this bug. ***

Comment 26

[Terri Preston]

Verified win XP trunk build 2002052809 and Mac OS trunk build 2002052803

Comment 27

[Cliff Palmer]

Resolved in Mozilla 1.0 Release Candidate 3 - Mozilla/5.0 (Windows; U; WinNT4.0;
en-US; rv:1.0rc3) Gecko/20020523, under NT4, SP6.  Thanks!