1093187 - 33.1 update snippets should not have actions="silent"

Status: RESOLVED FIXED

(Release Engineering :: Release Requests, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

See bug 1077643 comment 27.

Comment 1

[cmtalbert]

Catalin,

When this bug is fixed, I'd like you to retest the what's new page flows, please (with both pave-over and update installations).  Many thanks.

Comment 2

[Catalin Varga [QA][:VarCat]]

Sure, I'll do that. I'll clear the needinfo after I've completed the testing.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

<catlee> gavin: so we must have gotten wires crossed about what you wanted for 33.1. I see https://bugzilla.mozilla.org/show_bug.cgi?id=1077643#c35, and then in our 
         build notes nick notes that he forgot to disable whatsnew in the snippets, "as those are being handled in-app by 
         https://bugzilla.mozilla.org/show_bug.cgi?id=1077643"
<catlee> so then we landed changes for build2 to ensure that actions=silent would be in teh snippets
<catlee> gavin: https://wiki.mozilla.org/Releases/Firefox_33.1/BuildNotes#Issues
<catlee> https://bugzilla.mozilla.org/show_bug.cgi?id=1091282
<elan> Cc Dolske just in case: ^
<gavin> catlee: for the in-product fix, we kept the ability for snippets to override the built-in whatsnew
<gavin> catlee: the snippets can say "show whatsnew", "don't show whatsnew", or "no opinion on whatsnew"
<gavin> we need them to say "no opinion" , rather than "don't show whatsnew"
<gavin> catlee: from the snippets perspective, that means "no actions attribute at all"

Comment 4

[:Gavin Sharp [email: [e-mail]]]

So the core issue here is that "disable whatsnew in the snippets" is different than "don't add a whatsnew in the snippets" - we want the latter rather than the former.

Comment 5

[Hal Wine [:hwine] use NI!]

The snippets have been modified to remove the "action=" line, and repushed to betatest.

That is, ready for testing.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Looks like release/patcher-configs/mozRelease-branch-patcher2.cfg wasn't updated - does it make sense to do that in case we do additional builds?

Comment 7

[Hal Wine [:hwine] use NI!]

(In reply to :Gavin Sharp [email: [e-mail]] from comment #6)
> Looks like release/patcher-configs/mozRelease-branch-patcher2.cfg wasn't
> updated - does it make sense to do that in case we do additional builds?

Yep, and underway in bug 1091282

Comment 8

[Catalin Varga [QA][:VarCat]]

I verified the bug 1077643 after bug 1093187 was fixed  see bug 1077643 comment 38 .