Closed
Bug 109319
Opened 23 years ago
Closed 23 years ago
window.location.href missing Referer
Categories
(Core :: DOM: Core & HTML, defect, P1)
Core
DOM: Core & HTML
Tracking
()
VERIFIED
FIXED
mozilla0.9.7
People
(Reporter: mozilla, Assigned: bzbarsky)
References
()
Details
Attachments
(3 files, 1 obsolete file)
212 bytes,
text/html
|
Details | |
202 bytes,
text/html
|
Details | |
3.39 KB,
patch
|
fabian
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
If you try the script I setup on the url you will see
that if you click on the text (normal anchor) it will
display the referer. if you click on the rest of the
table the referer isn't included.
Here's the syntax I used:
onClick="JavaScript.window.location.href='<url>';"
This will make statistic for a site, script etc
think it didn't come from a link. That's bad ;)
![]() |
Assignee | |
Comment 1•23 years ago
|
||
Over to DOM0
Assignee: rogerl → jst
Status: UNCONFIRMED → NEW
Component: Javascript Engine → DOM Level 0
Ever confirmed: true
OS: Linux → All
QA Contact: pschwartau → amar
Hardware: PC → All
![]() |
Assignee | |
Comment 2•23 years ago
|
||
![]() |
Assignee | |
Comment 3•23 years ago
|
||
jst, would you review?
Comment 4•23 years ago
|
||
Shouldn't the referer be the caller's URI and not the current URI (which happen
to be the same in this case)? I.e. if you have frame_a and frame_b, and frame_a
set's frame_b's location the referer should be frame_a's URI, not frame_b's, no?
What does IE and 4.x do in such a case?
![]() |
Assignee | |
Comment 5•23 years ago
|
||
Comment on attachment 57252 [details] [diff] [review]
Patch to set referrer correctly
Yup. NS4 makes referrer be the caller's URI
Attachment #57252 -
Attachment is obsolete: true
![]() |
Assignee | |
Comment 6•23 years ago
|
||
![]() |
Assignee | |
Comment 7•23 years ago
|
||
![]() |
Assignee | |
Comment 8•23 years ago
|
||
![]() |
Assignee | |
Updated•23 years ago
|
Status: NEW → ASSIGNED
Priority: P3 → P1
Comment 9•23 years ago
|
||
Looks like LocationImpl::GetSourceDocument() and
LocationImpl::GetSourceBaseURL() can return w/o ever setting the out parameters
to null.
sr=jst with that fixed.
Updated•23 years ago
|
Attachment #57285 -
Flags: superreview+
Comment 10•23 years ago
|
||
Comment on attachment 57285 [details] [diff] [review]
Better patch
r=fabian after bz's explanation
Attachment #57285 -
Flags: review+
![]() |
Assignee | |
Comment 11•23 years ago
|
||
checked in.
![]() |
Assignee | |
Comment 12•23 years ago
|
||
.... and marking fixed, too. :)
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•