Closed
Bug 1093245
Opened 10 years ago
Closed 9 years ago
nsHTMLEditorStyle.cpp and nsHTMLEditRules.cpp potentially uninitialized variables
Categories
(Core :: DOM: Editor, defect)
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: milan, Assigned: milan)
References
Details
Attachments
(1 file, 1 obsolete file)
1.94 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
I imagine the component is wrong. nsHTMLEditor::GetInlinePropertyBase doesn't always initialize result, and nsHTMLEditRules::AlignBlockContents doesn't always initialize res, both of which are returned from those functions.
Assignee | ||
Updated•10 years ago
|
Attachment #8516144 -
Attachment is patch: true
Assignee | ||
Updated•10 years ago
|
Component: HTML: Parser → Editor
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8516144 -
Attachment is obsolete: true
Attachment #8516825 -
Flags: review?(ehsan.akhgari)
Comment 2•9 years ago
|
||
Comment on attachment 8516825 [details] [diff] [review] Initialize the return values Review of attachment 8516825 [details] [diff] [review]: ----------------------------------------------------------------- Out of curiosity, ow did you find these? :-) (And BTW the component is correct. Thanks for the fix!)
Attachment #8516825 -
Flags: review?(ehsan.akhgari) → review+
Comment 3•9 years ago
|
||
Aha, just saw bug 1092923. :-)
Assignee | ||
Comment 5•9 years ago
|
||
(In reply to :Ehsan Akhgari (not reading bugmail, needinfo? me!) from comment #2) > ... > > Out of curiosity, how did you find these? :-) > > (And BTW the component is correct. Thanks for the fix!) Believe it or not, caught my eye while the build was scrolling in the shell window :)
Assignee: nobody → milan
Keywords: checkin-needed
Comment 6•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/22728e4360f0
Keywords: checkin-needed
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/22728e4360f0
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•