Closed Bug 1093334 Opened 5 years ago Closed 5 years ago

Remove redundant Chromium headers from security/sandbox/linux

Categories

(Core :: Security, defect)

All
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: jld, Assigned: jld)

References

Details

Attachments

(3 files)

We have some copies of headers from Chromium, for using the Linux kernel seccomp-bpf functionality, in security/sandbox/linux.  But now we have a (partial) import of the Chromium Linux sandboxing code, so we could clean things up such that the Chromium code is all in security/sandbox/chromium/linux/sandbox and only non-Chromium code is in security/sandbox/linux, which would make the file security/sandbox/linux/LICENSE unnecessary.
Blocks: 1102197
(In reply to Jed Davis [:jld] from comment #1)
> Created attachment 8532271 [details] [diff] [review]
> Step 1: import more Chromium headers.

Just checking ... are these from commit 9522fad406dd161400daa518075828e47bd47f60?
Flags: needinfo?(jld)
(In reply to Bob Owen (:bobowen) from comment #5)
> (In reply to Jed Davis [:jld] from comment #1)
> > Created attachment 8532271 [details] [diff] [review]
> > Step 1: import more Chromium headers.
> 
> Just checking ... are these from commit
> 9522fad406dd161400daa518075828e47bd47f60?

Yes — and the hash is in the patch's commit message, for when someone runs git/hg log.
Flags: needinfo?(jld)
Comment on attachment 8532273 [details] [diff] [review]
Step 3: remove the old headers.

Review of attachment 8532273 [details] [diff] [review]:
-----------------------------------------------------------------

note: license still here i guess - do you plan to remove it?
Attachment #8532273 - Flags: review?(gdestuynder) → review+
(In reply to Guillaume Destuynder [:kang] from comment #7)
> note: license still here i guess - do you plan to remove it?

Yes; thanks for catching that.
You need to log in before you can comment on or make changes to this bug.