1093334 - Remove redundant Chromium headers from security/sandbox/linux

Status: RESOLVED FIXED

(Core :: Security, defect)

Description

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

We have some copies of headers from Chromium, for using the Linux kernel seccomp-bpf functionality, in security/sandbox/linux.  But now we have a (partial) import of the Chromium Linux sandboxing code, so we could clean things up such that the Chromium code is all in security/sandbox/chromium/linux/sandbox and only non-Chromium code is in security/sandbox/linux, which would make the file security/sandbox/linux/LICENSE unnecessary.

Comment 1

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Attachment: Step 1: import more Chromium headers.

Comment 2

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Attachment: Step 2: adjust the #includes.

Comment 3

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Attachment: Step 3: remove the old headers.

Comment 4

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Try run: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=5268a285efa8

Comment 5

[Bob Owen (:bobowen)]

(In reply to Jed Davis [:jld] from comment #1)
> Created attachment 8532271 [details] [diff] [review]
> Step 1: import more Chromium headers.

Just checking ... are these from commit 9522fad406dd161400daa518075828e47bd47f60?

Comment 6

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

(In reply to Bob Owen (:bobowen) from comment #5)
> (In reply to Jed Davis [:jld] from comment #1)
> > Created attachment 8532271 [details] [diff] [review]
> > Step 1: import more Chromium headers.
> 
> Just checking ... are these from commit
> 9522fad406dd161400daa518075828e47bd47f60?

Yes — and the hash is in the patch's commit message, for when someone runs git/hg log.

Comment 7

[Guillaume Destuynder [:kang] [this account is no longer active]]

Comment on attachment 8532273 [details] [diff] [review]
Step 3: remove the old headers.

Review of attachment 8532273 [details] [diff] [review]:
-----------------------------------------------------------------

note: license still here i guess - do you plan to remove it?

Comment 8

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

(In reply to Guillaume Destuynder [:kang] from comment #7)
> note: license still here i guess - do you plan to remove it?

Yes; thanks for catching that.

Comment 9

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e0f0ebdd1df5
https://hg.mozilla.org/integration/mozilla-inbound/rev/1e0944ec79a6
https://hg.mozilla.org/integration/mozilla-inbound/rev/0ffb57e3e9c9

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e0f0ebdd1df5
https://hg.mozilla.org/mozilla-central/rev/1e0944ec79a6
https://hg.mozilla.org/mozilla-central/rev/0ffb57e3e9c9