1093348 - Add a dropdown menu item to license options

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Demo Studio / Dev Derby, defect)

Description

[Justin Crawford [:hoosteeno] [:jcrawford]]

We need to allow uploads of proprietary-source content for the duration of the 10th Anniversary launch. In the dropdown where we let users choose a license, we need to add, "Author's EULA".

Like other changes part of the 10th anniversary work, this should be behind a waffle flag called "demos_10th". 

We will revert this change after the 10th anniversary press cycle winds down -- about 2 weeks later -- and we will want a way to identify the demos uploaded with this license.

Comment 1

[Jannis Leidel [:jezdez]]

That makes sense, I can do this tomorrow (Wed).

In case this is needed faster: The list of licenses can be extended conditionally by modifying the SubmissionNewForm/SubmissionEditForm to take a user object that is then used to check for the waffle flag and then populating the choices attribute of the license_name field in the __init__ method.

I would suggest to also extend the view that retrieves the list of demos to check for the flag and if it's falsy *exclude* demos with the "Author's EULA" license from the list of demos to show. That way we can disable the license and hide the demos effectively in the frontend, while still having access to the according demos in the admin.

What would be useful to know at some point is whether we'll be able to both remove the code modification and also the data involved or only the code. :hoosteeno can you shed some light on this?

Comment 2

[Luke Crouch [:groovecoder]]

I started to extend the licenses conditionally with the waffle flag, but I got stuck: https://github.com/mozilla/kuma/pull/2881

I'm going to start another branch to simply add the new license to the demos module along with the rest so we have something up for the demo authors to start uploading ASAP.

Comment 3

[MDN Team (:mdn-dev)]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/adda5dd6f956eb92f8bdee406d2ea4663705290a
fix bug 1093348 - add 'author' demo license

https://github.com/mozilla/kuma/commit/562ec226b5892bb0ca2b0a31776a095302dbcc73
Merge pull request #2882 from groovecoder/author-eula-1093348

fix bug 1093348 - add 'author' demo license

Comment 4

[Jannis Leidel [:jezdez]]

:groovecoder Could you file a follow-up bug so that we can properly fix this?

Comment 5

[Luke Crouch [:groovecoder]]

Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1093884

Comment 6

[Justin Crawford [:hoosteeno] [:jcrawford]]

Because the license is always followed by the word "License" in the UI, we shortened the dropdown item to "Author's". Just closing the loop on that.

> What would be useful to know at some point is whether we'll be able to both
> remove the code modification and also the data involved or only the code.
> :hoosteeno can you shed some light on this?

Both product and legal concerns oblige us to do this. We will keep this license option (and any demos uploaded with it) available for 2 weeks, and for no longer than 3.