1093363 - Unhandled rejection console message omits stack

Status: RESOLVED FIXED

(Toolkit :: Async Tooling, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

The message printed to the browser console for an unhandled promise rejection omits the full stack, making it harder to take action on.

It seems to have been omitted by accident, as it is added to variable and then not used.

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Are you talking of DOM Promise?

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: 0001-Bug-1093363-Add-stack-to-unhandled-promise-rejection.patch

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f1e5c1d35d6c

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to David Rajchenbach-Teller [:Yoric] (use "needinfo") from comment #1)
> Are you talking of DOM Promise?

No, Promise.jsm.

Comment 4

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 8516327 [details] [diff] [review]
0001-Bug-1093363-Add-stack-to-unhandled-promise-rejection.patch

Review of attachment 8516327 [details] [diff] [review]:
-----------------------------------------------------------------

Good .catch(), thanks.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/7eb74a10030b

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7eb74a10030b