1093387 - Hard to debug connection failures / errors

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Several parts of the WebIDE connect to a runtime workflow fail to report useful errors and / or handle rejections, leading to unhelpful errors or no stacks when there is an issue.

Let's improve the error handling.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Dave, you mentioned seeing these issues.  If you have specific steps for the issue you are seeing, note them here, and I'll check them along with anything else I clean up.

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: bz://1093387/jryans

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

/r/2365 - Bug 1093387 - Better WebIDE runtime error handling. r=ochameau

Pull down this commit:

hg pull review -r 7ad6fbeb4e7704c094536e25d63ce8535f325374

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0a68a938b5df

Comment 5

[Alexandre Poirot [:ochameau]]

https://reviewboard.mozilla.org/r/2363/#review1569

::: browser/devtools/webide/content/webide.js
(Diff revision 1)
> +             // |busyUntil| will listen for rejections.

This comment is a bit misleading.
You just want to ignore `initConnectionTelemetry` rejection, right?
While letting busyUntil handling connectToRuntime resolution.
If busyUntil listen for rejection, it will catch them.

::: browser/devtools/webide/modules/app-manager.js
(Diff revision 1)
> +      // |connectToRuntime| caller should listen for rejections.

Same thing here, you just want to ignore telemetry exceptions.

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Alexandre Poirot [:ochameau] from comment #5)
> https://reviewboard.mozilla.org/r/2363/#review1569
> 
> ::: browser/devtools/webide/content/webide.js
> (Diff revision 1)
> > +             // |busyUntil| will listen for rejections.
> 
> This comment is a bit misleading.
> You just want to ignore `initConnectionTelemetry` rejection, right?
> While letting busyUntil handling connectToRuntime resolution.
> If busyUntil listen for rejection, it will catch them.
> 
> ::: browser/devtools/webide/modules/app-manager.js
> (Diff revision 1)
> > +      // |connectToRuntime| caller should listen for rejections.
> 
> Same thing here, you just want to ignore telemetry exceptions.

As discussed on IRC, this is because uncaught promise tracking doesn't realize these rejection are handled elsewhere.

I filed bug 1121100 for this, and add the bug to these comments.  Also, I fixed a test failure.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bf3aa7fd5cb1

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://hg.mozilla.org/integration/fx-team/rev/c2498519af6e

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c2498519af6e

Comment 10

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: Bug 1093387 - Better WebIDE runtime error handling. r=ochameau