Hard to debug connection failures / errors

RESOLVED FIXED in Firefox 38

Status

RESOLVED FIXED
4 years ago
6 months ago

People

(Reporter: jryans, Assigned: jryans)

Tracking

(Depends on: 1 bug)

unspecified
Firefox 38

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Several parts of the WebIDE connect to a runtime workflow fail to report useful errors and / or handle rejections, leading to unhelpful errors or no stacks when there is an issue.

Let's improve the error handling.
(Assignee)

Comment 1

4 years ago
Dave, you mentioned seeing these issues.  If you have specific steps for the issue you are seeing, note them here, and I'll check them along with anything else I clean up.
Flags: needinfo?(dcamp)
(Assignee)

Updated

4 years ago
Summary: Hard to debug connection failures → Hard to debug connection failures / errors
(Assignee)

Updated

4 years ago
Assignee: nobody → jryans
Status: NEW → ASSIGNED
(Assignee)

Comment 2

4 years ago
Created attachment 8547778 [details]
MozReview Request: bz://1093387/jryans
Attachment #8547778 - Flags: review?(poirot.alex)
(Assignee)

Comment 3

4 years ago
/r/2365 - Bug 1093387 - Better WebIDE runtime error handling. r=ochameau

Pull down this commit:

hg pull review -r 7ad6fbeb4e7704c094536e25d63ce8535f325374
Attachment #8547778 - Flags: review?(poirot.alex) → review+
https://reviewboard.mozilla.org/r/2363/#review1569

::: browser/devtools/webide/content/webide.js
(Diff revision 1)
> +             // |busyUntil| will listen for rejections.

This comment is a bit misleading.
You just want to ignore `initConnectionTelemetry` rejection, right?
While letting busyUntil handling connectToRuntime resolution.
If busyUntil listen for rejection, it will catch them.

::: browser/devtools/webide/modules/app-manager.js
(Diff revision 1)
> +      // |connectToRuntime| caller should listen for rejections.

Same thing here, you just want to ignore telemetry exceptions.
(Assignee)

Updated

4 years ago
Depends on: 1121100
(Assignee)

Comment 6

4 years ago
(In reply to Alexandre Poirot [:ochameau] from comment #5)
> https://reviewboard.mozilla.org/r/2363/#review1569
> 
> ::: browser/devtools/webide/content/webide.js
> (Diff revision 1)
> > +             // |busyUntil| will listen for rejections.
> 
> This comment is a bit misleading.
> You just want to ignore `initConnectionTelemetry` rejection, right?
> While letting busyUntil handling connectToRuntime resolution.
> If busyUntil listen for rejection, it will catch them.
> 
> ::: browser/devtools/webide/modules/app-manager.js
> (Diff revision 1)
> > +      // |connectToRuntime| caller should listen for rejections.
> 
> Same thing here, you just want to ignore telemetry exceptions.

As discussed on IRC, this is because uncaught promise tracking doesn't realize these rejection are handled elsewhere.

I filed bug 1121100 for this, and add the bug to these comments.  Also, I fixed a test failure.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bf3aa7fd5cb1
https://hg.mozilla.org/mozilla-central/rev/c2498519af6e
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38

Updated

4 years ago
Flags: needinfo?(dcamp)
(Assignee)

Comment 9

4 years ago
Comment on attachment 8547778 [details]
MozReview Request: bz://1093387/jryans
Attachment #8547778 - Attachment is obsolete: true
Attachment #8618545 - Flags: review+
(Assignee)

Comment 10

4 years ago
Created attachment 8618545 [details]
MozReview Request: Bug 1093387 - Better WebIDE runtime error handling. r=ochameau

Updated

6 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.