[Stingray][Home] move libraries to tv-shared folder

RESOLVED FIXED

Status

Firefox OS
Gaia
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: johnhu, Assigned: johnhu)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 attachment)

There are few libraries should be moved to shared folder. In order to not pollute phone's shared folder. We need to create a tv-shared folder and use app's build script to copy them.
Created attachment 8516470 [details] [review]
TV shared

Hi all,

This is the patch to support tv_shared folder. Apps who wants to use files in tv_shared must include the following codes to build/build.js:

  var helperPath = utils.joinPath('..', '..', 'tv_apps', 'tv_build',
                                  'tv_shared_helper.js');
  require(helperPath).TVSharedHelper.execute(options);

Please give me feedback and review this patch. Thanks.
Attachment #8516470 - Flags: review?(tzhuang)
Attachment #8516470 - Flags: review?(rexboy)
Attachment #8516470 - Flags: feedback?(yliao)
Comment on attachment 8516470 [details] [review]
TV shared

remove the r? from rex since he is fully loaded.
Attachment #8516470 - Flags: review?(rexboy)
Comment on attachment 8516470 [details] [review]
TV shared

Thank you! Looks good!
Attachment #8516470 - Flags: feedback?(yliao) → feedback+
Comment on attachment 8516470 [details] [review]
TV shared

r+ with nits.

Thanks for the patch.
Attachment #8516470 - Flags: review?(tzhuang) → review+
Blocks: 1067793
merged to master:
https://github.com/mozilla-b2g/gaia/commit/38e2e51f3d8c4be2030313201b009a274b628908
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Depends on: 1095219
You need to log in before you can comment on or make changes to this bug.