1093475 - When a call URL is deleted/blocked, use the proper session

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect)

Description

[Matthew N. [:MattN]]

+++ This bug was initially created as a clone of Bug #1065155 +++

Bug 1065155 was supposed to cover deleting (aka. blocking) call URLs but it didn't do so: https://mxr.mozilla.org/mozilla-central/source/browser/components/loop/content/js/client.js?rev=e2f7534c7687#185

I haven't manually testing but my understanding is that a user currently can't block a call from a call URL that was generated while logged in to Loop.

Comment 1

[Maire Reavy [:mreavy]]

Matt -- Will this bug effectively go away when we move to Rooms?

Comment 2

[Matthew N. [:MattN]]

I think so. It may be a good idea to fix it for the earlier releases to deal with abuse.

Comment 3

[Matthew N. [:MattN]]

Mark, what would be the best way to the session which created the call URL we're about to delete?

Comment 4

[Matthew N. [:MattN]]

What would be the best way to find out the session which created the call URL we're about to delete?

e.g. Call comes in to https://hello.firefox.com/#call/04-92QkSxfoo and I click "decline and block". Do we currently keep track of which of the two call requests returned the call after the push?

Comment 5

[Mark Banner (:standard8)]

Attachment: When a Loop call URL is deleted/blocked, use the proper session.

I took a look, and the patch was easy, so I just went ahead and fixed it.

In LoopCalls, we already keep track of the sessionType in the _getCalls/_processCalls functions. The sessionType is passed to the window (via callData), and stored in the conversation model.

The simple fix is then just to extract the information, and use it in the delete function.

Comment 6

[Mark Banner (:standard8)]

Oh forgot to say, I tested a few scenarios such as:

- Whilst logged out: get a call url & start incoming call from url & block it.
- Whilst logged in: get a call url & start incoming call from url & block it.
- Whilst logged out: generate a call url, then log in, start incoming call from url & block it.

They all worked fine.

Comment 7

[Mark Banner (:standard8)]

I just checked beta, and the sessionType should be available in the right places there as well. So there shouldn't be a need for a different patch on aurora/beta.

Comment 8

[Mark Banner (:standard8)]

Comment on attachment 8517373 [details] [diff] [review]
When a Loop call URL is deleted/blocked, use the proper session.

Switching to Mike as he's around

Comment 9

[Mike de Boer [:mikedeboer]]

Comment on attachment 8517373 [details] [diff] [review]
When a Loop call URL is deleted/blocked, use the proper session.

Review of attachment 8517373 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 10

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/7902458c79ec

Comment 11

[Maire Reavy [:mreavy]]

Comment on attachment 8517373 [details] [diff] [review]
When a Loop call URL is deleted/blocked, use the proper session.

Approval Request Comment
[Feature/regressing bug #]: Blocking a call (link-clicked call) when the user is logged in

[User impact if declined]: If declined, there is no way for a user to block a call if they are logged in aside from logging out of the system or changing profiles.

[Describe test coverage new/current, TBPL]: tbpl, manual testing

[Risks and why]: No risk outside of Loop, minimal risk to Loop.  Without this, a logged-in user can't block a call for link they shared with someone.  It's potentially an abuse/harrassment issue.

[String/UUID change made/needed]: No strings

Comment 12

[Maire Reavy [:mreavy]]

[Tracking Requested - why for this release]: See Comment 11

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7902458c79ec

Comment 14

[Randell Jesup [:jesup] (needinfo me)]

Checked on m-c tbpl builds, in a bunch of variations.  Works as it should.  Try runs for Aurora and Beta running.

Comment 15

[Randell Jesup [:jesup] (needinfo me)]

Tested on Aurora Try build, no problems
https://hg.mozilla.org/releases/mozilla-aurora/rev/7b1cbdeed5d8

Comment 16

[Randell Jesup [:jesup] (needinfo me)]

Tested on Beta Try build, no problems
https://hg.mozilla.org/releases/mozilla-beta/rev/caa27159afeb

Aurora and beta landing per discussion with lmandel

Comment 17

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8517373 [details] [diff] [review]
When a Loop call URL is deleted/blocked, use the proper session.

Previously provided approval via irc. Marking the bug with approval for record keeping.

Comment 18

[Paul Silaghi, QA [:pauly]]

Verified FF 34b7, 35.0a2 (2014-11-10) Win 7