Closed Bug 1093497 Opened 5 years ago Closed 5 years ago

Fix Version Attributes in Loop Mobile Client

Categories

(Firefox OS Graveyard :: Gaia::Loop, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: oteo, Assigned: dcoloma)

References

Details

(Whiteboard: [mobile app][Test-Run1][tef-triage][loop in v1.1])

Attachments

(4 files)

Add version attribute to manifest.webapp as it was not include so far and 
ensure file config.js in mozilla-b2g/firefoxos-loop-client github branches does not include the same version value than the “official” apps, as otherwise the telemetry server will aggregate the real users data with the development one.

To be clear, the values should be:

 - 1.1 Branch:  manifest.webapp and config.js version should be ‘1.1d’ - where "d" denotes development.
 - master Branch: manifest.webapp and config.js version should be ‘1.1.1d’ - where "d" denotes development.
Blocks: Loopmov_1_1
Attachment #8516627 - Attachment description: Link to master PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/286 → Link to Github pull-request: https://github.com/mozilla-b2g/firefoxos-loop-client/pull/287
Attachment #8516627 - Flags: review?(josea.olivera)
Attachment #8516634 - Attachment description: Link to 1.1 PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/287 → Link to Github pull-request: https://github.com/mozilla-b2g/firefoxos-loop-client/pull/287
Attachment #8516634 - Flags: review?(josea.olivera)
Assignee: nobody → dcoloma
Status: NEW → ASSIGNED
Whiteboard: [mobile app][Test-Run1][tef-triage][loop approved for 1.1]
Comment on attachment 8516634 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/firefoxos-loop-client/pull/287

LGTM. r=me

Thanks Daniel!
Attachment #8516634 - Flags: review?(josea.olivera) → review+
Landed on master branch at:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/483d00279967045b1cab48ce00b41b917bcb6a93

Landed on 1.1 branch at:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/2e7c3c2a254b61c1b7e483301fb3fd7917710a47
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [mobile app][Test-Run1][tef-triage][loop approved for 1.1] → [mobile app][Test-Run1][tef-triage][loop in v1.1]
Attached image config.png
Tested 

Flame
eng
v2.0
Gecko-dde9d61
Gaia-7b8df99
Loop version: 1.1 , 2e7c3c2
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.