[RIL] Should present the "number" for outgoing call in CLCC

RESOLVED FIXED in 2.1 S8 (7Nov)

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: aknow, Assigned: aknow)

Tracking

unspecified
2.1 S8 (7Nov)
x86_64
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
This cause the fail in marionette test, ex: test_temporary_clir.js
In the test case, we try to send the request "gsm cancel <number>". However, the number becomes empty because it is not shown in CLCC.
(Assignee)

Comment 1

4 years ago
Created attachment 8516546 [details] [review]
PR 118
Attachment #8516546 - Flags: review?(htsai)

Comment 2

4 years ago
Comment on attachment 8516546 [details] [review]
PR 118

Steal r? if you don't mind :)
Attachment #8516546 - Flags: review?(htsai) → review?(echen)

Comment 3

4 years ago
(In reply to Szu-Yu Chen [:aknow] from comment #1)
> Created attachment 8516546 [details] [review]
> PR 118

Please see my comments in github, thank you.
(In reply to Edgar Chen [:edgar][:echen] from comment #2)
> Comment on attachment 8516546 [details] [review]
> PR 118
> 
> Steal r? if you don't mind :)

No problem, thank you very much :P
(Assignee)

Comment 5

4 years ago
(In reply to Edgar Chen [:edgar][:echen] from comment #3)
> (In reply to Szu-Yu Chen [:aknow] from comment #1)
> > Created attachment 8516546 [details] [review]
> > PR 118
> 
> Please see my comments in github, thank you.

Fixed. Thank you.

Comment 6

4 years ago
Comment on attachment 8516546 [details] [review]
PR 118

Thank you.
Attachment #8516546 - Flags: review?(echen) → review+

Comment 7

4 years ago
Try with qemu changes looks good: https://tbpl.mozilla.org/?tree=Try&rev=31e2718246fa \o/

Updated

4 years ago
Keywords: checkin-needed
(In reply to Edgar Chen [:edgar][:echen] from comment #7)
> Try with qemu changes looks good:
> https://tbpl.mozilla.org/?tree=Try&rev=31e2718246fa \o/

\o/
https://github.com/mozilla-b2g/platform_external_qemu/commit/67f2907bc340bad250b4ea6ce2902b52896c9ef0
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S8 (7Nov)
Hi Aknow,
Could you help provide a pull request to kk-branch? Thank you.
Flags: needinfo?(szchen)
(Assignee)

Comment 13

4 years ago
Created attachment 8533581 [details] [review]
[platform_external_qemu][b2g-kitkat] PR 122
Flags: needinfo?(szchen)
Attachment #8533581 - Flags: review+
(Assignee)

Comment 14

4 years ago
checkin-needed for PR 122
It's the PR for kk branch
Keywords: checkin-needed

Updated

4 years ago
Blocks: 1090359

Updated

4 years ago
Blocks: 1124557

Updated

4 years ago
No longer blocks: 1124557
You need to log in before you can comment on or make changes to this bug.