Closed
Bug 1093521
Opened 11 years ago
Closed 11 years ago
[RTSP] An extra PLAY request is send after end-of-stream
Categories
(Firefox OS Graveyard :: RTSP, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S8 (7Nov)
People
(Reporter: jhao, Assigned: jhao)
Details
Attachments
(1 file, 1 obsolete file)
|
1.03 KB,
patch
|
Details | Diff | Splinter Review |
After end-of-stream, tcpdump shows that occasionally an extra PLAY request is send.
The reason is that the play action by media decoder is delayed 200ms by a timer. If the playback happens to end in the 200ms, RTSPSource's state becomes CONNECTED, by the time the play action actually takes place.
The solution suggested by Ethan and Benjamin is to stop the play and pause timer when then playback ends.
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → jhao
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8516572 -
Flags: review?(ettseng)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8516572 [details] [diff] [review]
Stop play and pause timer when playback ends
Review of attachment 8516572 [details] [diff] [review]:
-----------------------------------------------------------------
This is a side-effect resulted from bug 1080470.
Thanks for fixing this!
Attachment #8516572 -
Flags: review?(ettseng) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Add commit message.
Try server results:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=03cdbcad28b5
Attachment #8516572 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 4•11 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S8 (7Nov)
You need to log in
before you can comment on or make changes to this bug.
Description
•