[RTSP] An extra PLAY request is send after end-of-stream

RESOLVED FIXED in 2.1 S8 (7Nov)

Status

Firefox OS
RTSP
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jhao, Assigned: jhao)

Tracking

unspecified
2.1 S8 (7Nov)
x86
Gonk (Firefox OS)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
After end-of-stream, tcpdump shows that occasionally an extra PLAY request is send.

The reason is that the play action by media decoder is delayed 200ms by a timer. If the playback happens to end in the 200ms, RTSPSource's state becomes CONNECTED, by the time the play action actually takes place.

The solution suggested by Ethan and Benjamin is to stop the play and pause timer when then playback ends.
(Assignee)

Updated

4 years ago
Assignee: nobody → jhao
(Assignee)

Comment 1

4 years ago
Created attachment 8516572 [details] [diff] [review]
Stop play and pause timer when playback ends
Attachment #8516572 - Flags: review?(ettseng)

Comment 2

4 years ago
Comment on attachment 8516572 [details] [diff] [review]
Stop play and pause timer when playback ends

Review of attachment 8516572 [details] [diff] [review]:
-----------------------------------------------------------------

This is a side-effect resulted from bug 1080470.
Thanks for fixing this!
Attachment #8516572 - Flags: review?(ettseng) → review+
(Assignee)

Comment 3

4 years ago
Created attachment 8517159 [details] [diff] [review]
Stop play and pause timer when playback ends

Add commit message.

Try server results:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=03cdbcad28b5
Attachment #8516572 - Attachment is obsolete: true
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1505c9f42b2f
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S8 (7Nov)
You need to log in before you can comment on or make changes to this bug.