All users were logged out of Bugzilla on October 13th, 2018

[Stingray][Settings] add settings list to settings app

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: johnhu, Assigned: johnhu)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 attachment)

The base settings app will be landed at bug 1092934. This issue tracks the support of settings list and setting detail:

settings list: it is a list panel of a group of settings
settings detail: it is a option list when a settings item is clicked.
Since I got the wrong idea from UX's spec, I will left this bug for dealing with creating settings list. And there is no more settings detail is.

I will file another bug to implement the "Option Menu" and use it for landing app.
Blocks: 1094069
Summary: [Stingray][Settings] add settings list and settings detail panel to settings app → [Stingray][Settings] add settings list to settings app
Created attachment 8517295 [details] [review]
add settings list

Hi dwi2,

Please review this patch. Thanks.
Attachment #8517295 - Flags: review?(tzhuang)
Comment on attachment 8517295 [details] [review]
add settings list

I forgot to ask evelyn review the first patch of stingray settings app. 
So we should ask her to review this patch.
Attachment #8517295 - Flags: review?(ehung)
Comment on attachment 8517295 [details] [review]
add settings list

This patch looks good to me in general. But I left some comments on PR that I hope you could address. 

Thanks.
Attachment #8517295 - Flags: review?(tzhuang) → review+
gaia-try is green:
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=f591bb0b3da9

merged to master:
https://github.com/mozilla-b2g/gaia/commit/284253475469b58d549fa48aee67dd1fc814dbc9
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Attachment #8517295 - Flags: review?(ehung)
You need to log in before you can comment on or make changes to this bug.