1093602 - Disable logshake feature on v2.1

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Developer Tools, defect)

Description

[:gerard-majax]

This is exposed on settings but gecko patch only landed on master.

Comment 1

[:gerard-majax]

[Blocking Requested - why for this release]: Safer to hide if not supported.

Comment 2

[:gerard-majax]

Attachment: Gaia PR

Comment 3

[Jan Keromnes [:janx]]

Comment on attachment 8516666 [details] [review]
Gaia PR

A backout would have been nicer, but a new patch is probably safer if there were conflicts.

r+ but only if you also remove https://github.com/mozilla-b2g/gaia/blob/v2.1/apps/system/jsdoc.json#L9 and the tests pass.

Comment 4

[:gerard-majax]

(In reply to Jan Keromnes [:janx] from comment #3)
> Comment on attachment 8516666 [details] [review]
> Gaia PR
> 
> A backout would have been nicer, but a new patch is probably safer if there
> were conflicts.

Yes, a simple git revert was failing.

> 
> r+ but only if you also remove
> https://github.com/mozilla-b2g/gaia/blob/v2.1/apps/system/jsdoc.json#L9 and
> the tests pass.

Done. Let's wait for try :)

Comment 5

[:gerard-majax]

https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=9e329cfe82f7

Comment 6

[Jan Keromnes [:janx]]

Axel, just FYI, this change is removing two strings from the system app in 2.1 ("logsSaved" and "logsFailed"). They'll remain present in master and future branches.

Not sure there is anything more to do, but I thought I'd let you know.

Comment 7

[Francesco Lodolo [:flod]]

Please do not remove strings from 2.1 (Pike is on PTO this week).

Remove the feature if you need, but not the strings, they just create unnecessary noise for tools.

Comment 8

[:gerard-majax]

(In reply to Francesco Lodolo [:flod] from comment #7)
> Please do not remove strings from 2.1 (Pike is on PTO this week).
> 
> Remove the feature if you need, but not the strings, they just create
> unnecessary noise for tools.

Will do. Meanwhile, mostly green at: https://tbpl.mozilla.org/?tree=Gaia-Try&rev=9e329cfe82f7
I retriggered Accessibility tests.

Comment 9

[:gerard-majax]

Francesco, pushed again that should be good for your l10n side.

Comment 10

[Francesco Lodolo [:flod]]

(In reply to Alexandre LISSY :gerard-majax from comment #9)
> Francesco, pushed again that should be good for your l10n side.

Thanks, looks good now.

Comment 11

[:gerard-majax]

Green after retrigger: https://tbpl.mozilla.org/?tree=Gaia-Try&rev=9e329cfe82f7

Comment 12

[:gerard-majax]

Comment on attachment 8516666 [details] [review]
Gaia PR

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): missing gecko part of the logshake feature on 2.1
[User impact] if declined: user will see the option in developper settings, but enabling/disabling the option will do nothing
[Testing completed]: on device with green try
[Risk to taking this patch] (and alternatives if risky): low, we are only removing a menu entry and related tests
[String changes made]: none, as suggested in comment 7 we are keeping the strings even if they are not used anymore.

Comment 13

[Gregor Wagner [:gwagner]]

NI fabrice since its 2.1 only.

Comment 14

[:gerard-majax]

Green: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=666f2eba18cb

Comment 15

[:gerard-majax]

https://github.com/mozilla-b2g/gaia/commit/57b111ff404345006e13e576ddeb498edc21dd5d

Comment 16

[Lance（leave from Mozilla）]

Hi Alex,
    Can you provide the bug step and video for me? Thanks.

Comment 17

[:gerard-majax]

(In reply to Lance from comment #16)
> Hi Alex,
>     Can you provide the bug step and video for me? Thanks.

No. I don't even understand why you would need a video.

Comment 18

[Johan Lorenzo [:jlorenzo]]

(In reply to Lance from comment #16)
This is a feature removal. You shouldn't be able to see the option in the developers after this patch. I don't a video is necessary here. Why would you need one?

Comment 19

[Lance（leave from Mozilla）]

This issue has been verified successfully on Flame 2.1, we can't see the logshake option in developer settings.
See attachment: 1034.MP4
Reproducing rate: 0/5

Flame 2.1 version:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-2g34_v2_1/rev/18fb67530b22
Build-ID        20141130001203
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141130.034738
FW-Date         Sun Nov 30 03:47:49 EST 2014
Bootloader      L1TC00011880

Comment 20

[Lance（leave from Mozilla）]

Attachment: 1034.MP4