Closed
Bug 1093602
Opened 10 years ago
Closed 10 years ago
Disable logshake feature on v2.1
Categories
(Firefox OS Graveyard :: Developer Tools, defect)
Tracking
(b2g-v2.1 verified, b2g-v2.2 wontfix)
VERIFIED
FIXED
2.1 S8 (7Nov)
People
(Reporter: gerard-majax, Assigned: gerard-majax)
Details
(Whiteboard: [systemsfe])
Attachments
(2 files)
46 bytes,
text/x-github-pull-request
|
janx
:
review+
fabrice
:
approval-gaia-v2.1+
|
Details | Review |
2.23 MB,
video/mp4
|
Details |
This is exposed on settings but gecko patch only landed on master.
Assignee | ||
Comment 1•10 years ago
|
||
[Blocking Requested - why for this release]: Safer to hide if not supported.
blocking-b2g: --- → 2.1?
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8516666 -
Flags: review?(janx)
Comment 3•10 years ago
|
||
Comment on attachment 8516666 [details] [review] Gaia PR A backout would have been nicer, but a new patch is probably safer if there were conflicts. r+ but only if you also remove https://github.com/mozilla-b2g/gaia/blob/v2.1/apps/system/jsdoc.json#L9 and the tests pass.
Attachment #8516666 -
Flags: review?(janx) → review+
Assignee | ||
Comment 4•10 years ago
|
||
(In reply to Jan Keromnes [:janx] from comment #3) > Comment on attachment 8516666 [details] [review] > Gaia PR > > A backout would have been nicer, but a new patch is probably safer if there > were conflicts. Yes, a simple git revert was failing. > > r+ but only if you also remove > https://github.com/mozilla-b2g/gaia/blob/v2.1/apps/system/jsdoc.json#L9 and > the tests pass. Done. Let's wait for try :)
Assignee | ||
Comment 5•10 years ago
|
||
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=9e329cfe82f7
Comment 6•10 years ago
|
||
Axel, just FYI, this change is removing two strings from the system app in 2.1 ("logsSaved" and "logsFailed"). They'll remain present in master and future branches. Not sure there is anything more to do, but I thought I'd let you know.
Flags: needinfo?(l10n)
Comment 7•10 years ago
|
||
Please do not remove strings from 2.1 (Pike is on PTO this week). Remove the feature if you need, but not the strings, they just create unnecessary noise for tools.
Flags: needinfo?(l10n)
Assignee | ||
Comment 8•10 years ago
|
||
(In reply to Francesco Lodolo [:flod] from comment #7) > Please do not remove strings from 2.1 (Pike is on PTO this week). > > Remove the feature if you need, but not the strings, they just create > unnecessary noise for tools. Will do. Meanwhile, mostly green at: https://tbpl.mozilla.org/?tree=Gaia-Try&rev=9e329cfe82f7 I retriggered Accessibility tests.
Assignee | ||
Comment 9•10 years ago
|
||
Francesco, pushed again that should be good for your l10n side.
Flags: needinfo?(francesco.lodolo)
Comment 10•10 years ago
|
||
(In reply to Alexandre LISSY :gerard-majax from comment #9) > Francesco, pushed again that should be good for your l10n side. Thanks, looks good now.
Flags: needinfo?(francesco.lodolo)
Assignee | ||
Comment 11•10 years ago
|
||
Green after retrigger: https://tbpl.mozilla.org/?tree=Gaia-Try&rev=9e329cfe82f7
Assignee | ||
Comment 12•10 years ago
|
||
Comment on attachment 8516666 [details] [review] Gaia PR [Approval Request Comment] [Bug caused by] (feature/regressing bug #): missing gecko part of the logshake feature on 2.1 [User impact] if declined: user will see the option in developper settings, but enabling/disabling the option will do nothing [Testing completed]: on device with green try [Risk to taking this patch] (and alternatives if risky): low, we are only removing a menu entry and related tests [String changes made]: none, as suggested in comment 7 we are keeping the strings even if they are not used anymore.
Attachment #8516666 -
Flags: approval-gaia-v2.1?
Updated•10 years ago
|
Flags: needinfo?(fabrice)
Attachment #8516666 -
Flags: approval-gaia-v2.1? → approval-gaia-v2.1+
Assignee | ||
Comment 14•10 years ago
|
||
Green: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=666f2eba18cb
Assignee | ||
Comment 15•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/57b111ff404345006e13e576ddeb498edc21dd5d
Status: NEW → RESOLVED
blocking-b2g: 2.1? → ---
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe]
Target Milestone: --- → 2.1 S8 (7Nov)
Updated•10 years ago
|
status-b2g-v2.1:
--- → fixed
status-b2g-v2.2:
--- → wontfix
Comment 16•10 years ago
|
||
Hi Alex, Can you provide the bug step and video for me? Thanks.
Flags: needinfo?(lissyx+mozillians)
Assignee | ||
Comment 17•10 years ago
|
||
(In reply to Lance from comment #16) > Hi Alex, > Can you provide the bug step and video for me? Thanks. No. I don't even understand why you would need a video.
Flags: needinfo?(lissyx+mozillians)
Comment 18•10 years ago
|
||
(In reply to Lance from comment #16) This is a feature removal. You shouldn't be able to see the option in the developers after this patch. I don't a video is necessary here. Why would you need one?
Flags: needinfo?(liuke)
Comment 19•10 years ago
|
||
This issue has been verified successfully on Flame 2.1, we can't see the logshake option in developer settings. See attachment: 1034.MP4 Reproducing rate: 0/5 Flame 2.1 version: Gaia-Rev ccb49abe412c978a4045f0c75abff534372716c4 Gecko-Rev https://hg.mozilla.org/releases/mozilla-2g34_v2_1/rev/18fb67530b22 Build-ID 20141130001203 Version 34.0 Device-Name flame FW-Release 4.4.2 FW-Incremental eng.cltbld.20141130.034738 FW-Date Sun Nov 30 03:47:49 EST 2014 Bootloader L1TC00011880
Flags: needinfo?(liuke)
Updated•10 years ago
|
Comment 20•10 years ago
|
||
Updated•10 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•