[Progress Bar] [Follow up] Progressbar is showed at the top of the screen for a second in fullscreen apps

VERIFIED FIXED in Firefox OS v2.2

Status

Firefox OS
Gaia::System
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: albertopq, Assigned: albertopq)

Tracking

({verifyme})

unspecified
2.1 S9 (21Nov)
x86
Mac OS X
verifyme

Firefox Tracking Flags

(tracking-b2g:backlog, b2g-v2.1 affected, b2g-v2.2 verified)

Details

(Whiteboard: [systemsfe])

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Follow up of bug 1087042.

On a fullscreen app, when pulling down the rocket bar, the progressbar is shown missplaced for a second

http://youtu.be/onUrLUdsxcM
(Assignee)

Updated

3 years ago
Blocks: 1087042
[Blocking Requested - why for this release]:
Since we blocked on bug 1087042, we should probably also block on this one.
blocking-b2g: --- → 2.1?
Too late to block.
blocking-b2g: 2.1? → backlog
(Assignee)

Updated

3 years ago
Assignee: nobody → apastor
(Assignee)

Comment 3

3 years ago
Created attachment 8521446 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/26069
Attachment #8521446 - Flags: review?(mhenretty)
(Assignee)

Comment 4

3 years ago
Hey Brogan, could you please check if this patch fixes the problem you reported in bug 1087042? Thanks!
Flags: needinfo?(bzumwalt)
With the patch I am not seeing the issue occur on Flame 2.2

The loading bar is below the search bar for entirety of page load.

Device: Flame 2.2 Master (319mb)(Kitkat Base)(Shallow Flash)
BuildID: 20141112040208
Gaia: 12586468190bf0eae8d3d1f43a8c199a45f3fec8
Gecko: 688f821edcd4
Version: 36.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(bzumwalt) → needinfo?(ktucker)
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
Comment on attachment 8521446 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/26069

Forwarding to :kgrandon, as he is more familiar with this area.
Attachment #8521446 - Flags: review?(mhenretty) → review?(kgrandon)
Comment on attachment 8521446 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/26069

I think ideally we want to animate this along with dragging down the statusbar, but this isn't so bad. Thanks!
Attachment #8521446 - Flags: review?(kgrandon) → review+
In master: https://github.com/mozilla-b2g/gaia/commit/69ca5a030d42fff8eeb65de1012fd984cc1ab833
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S9 (21Nov)

Comment 9

3 years ago
Verified the bug is fixed on 2.2 Flame

Progress-bar is showed only below the rockerbar search

Device: Flame 2.2 (319mb)(Kitkat Base)(Shallow Flash)
BuildID: 20141124100136
Gaia: aad40f6d6eb8f626c6a20db55b9f00d2e832f113
Gecko: be4ba3d5ca9a
Version: 36.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0
==================================================================
Adding "verifyme" for 2.1 patch uplift
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage?]
status-b2g-v2.1: --- → affected
status-b2g-v2.2: --- → verified
Flags: needinfo?(ktucker)
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
Keywords: verifyme
blocking-b2g: backlog → ---
tracking-b2g: --- → backlog
You need to log in before you can comment on or make changes to this bug.