Closed
Bug 1093750
Opened 10 years ago
Closed 8 years ago
Toolbar items should have tooltips in Customize Mode
Categories
(Firefox :: Toolbars and Customization, defect)
Tracking
()
VERIFIED
FIXED
Firefox 49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: sevaan, Assigned: ktbee, Mentored)
References
Details
(Whiteboard: [outreachy-12])
Attachments
(1 file)
In customize mode there is no easy way to determine what the icons in your toolbar are, unless you first drag it into the Customize tray in order to see the label. Adding tooltips would solve this. http://cl.ly/image/2K3g1o3m3n29
Flags: firefox-backlog+
Comment 2•8 years ago
|
||
Katie, would you like to work on this bug next? You should look at the createOrUpdateWrapper function in CustomizeMode.jsm and see what attribute we need to forward to get the tooltiptext to show up correctly on the wrapper.
Mentor: jaws
Flags: needinfo?(kbroida)
Whiteboard: [outreachy-12]
Updated•8 years ago
|
Assignee: nobody → kbroida
Status: NEW → ASSIGNED
Assignee | ||
Comment 4•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/48885/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/48885/
Attachment #8745163 -
Flags: review?(jaws)
Updated•8 years ago
|
Points: --- → 2
Updated•8 years ago
|
Attachment #8745163 -
Flags: review?(jaws)
Comment 5•8 years ago
|
||
Comment on attachment 8745163 [details] MozReview Request: Bug 1093750 - Adds tooltips to icons in Customize mode r?jaws https://reviewboard.mozilla.org/r/48885/#review46103 This is good but we should have a test that confirms this is working. I looked through the tests in /browser/components/customizableui/test/ and didn't see any that could be easily added to. You can create a new test that does the following: ''' add_task(function* check_tooltips_in_navbar() { yield startCustomizing(); let homeButtonWrapper = document.getElementById("wrapper-home-button"); let homeButton = document.getElementById("home-button"); is(homeButtonWrapper.getAttribute("tooltiptext"), homeButton.getAttribute("label"), "the wrapper's tooltip should match the button's label"); ok(homeButtonWrapper.getAttribute("tooltiptext"), "the button should have tooltip text"); }); ''' You could also add a test for the "title" attribute, though I'm not sure what toolbaritems use "title".
Assignee | ||
Comment 6•8 years ago
|
||
Comment on attachment 8745163 [details] MozReview Request: Bug 1093750 - Adds tooltips to icons in Customize mode r?jaws Review request updated; see interdiff: https://reviewboard.mozilla.org/r/48885/diff/1-2/
Attachment #8745163 -
Flags: review?(jaws)
Comment 7•8 years ago
|
||
Comment on attachment 8745163 [details] MozReview Request: Bug 1093750 - Adds tooltips to icons in Customize mode r?jaws https://reviewboard.mozilla.org/r/48885/#review46747 Looks good!
Attachment #8745163 -
Flags: review?(jaws) → review+
Comment 8•8 years ago
|
||
Whoops! Looks like I forgot to mark this as checkin-needed. Katie, in the future if you notice that it is missing the checkin-needed keyword you can add it yourself too.
Keywords: checkin-needed
Comment 10•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d1e1387b1d1d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Comment 11•8 years ago
|
||
I have reproduced this bug with Nightly 36.0a1(2014-11-04) on Windows 10, 64 bit! The Bug's fix is now verified on latest Beta 49.0b2 Build ID 20160808002253 User Agent Mozilla/5.0 (Windows NT 10.0; WOW64; rv:49.0) Gecko/20100101 Firefox/49.0 [bugday-20160810]
Assignee | ||
Updated•8 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•