1093789 - [Lockscreen] Lockscreen will appear briefly and then go away, after switching screen off

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[[:SalvadorR]]

Attachment: logcat_20141104_1105.txt

Description:
When user goes into settings and turns lockscreen off and quickly locks the screen with the power button, when the power button is pressed again, the lockscreen will appear for a brief second and then go away
   
Repro Steps:
1) Update a Flame device to BuildID: 20141104001202
2) Navigate to Settings> Lockscreen and disable lockscreen
3) Quickly press the power button after disabling lockscreen
4) Press the power button again to unlock the screen
5) Observe lockscreen
  
Actual:
Lockscreen appears for a split second
  
Expected: 
Lockscreen never appears

Environmental Variables:
Device: Flame 2.1 (319mb) KK Shallow Flash
BuildID: 20141104001202
Gaia: 8b0cf889ae0d48a9eb7ecdcb9b67590de45cc5e5
Gecko: 388b03efe92d
Gonk: 48835395daa6a49b2781db62c50805bd6ca24077e
Version: 34.0 (2.1)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
  
Repro frequency: 3/5
See attached: Video, Logcat
http://youtu.be/GXPtBDXq4AI

Comment 1

[[:SalvadorR]]

This issue also occurs on Flame 2.2, but will leave the device stuck in the lockscreen

Result: Device becomes stuck on lockscreen

Flame 2.2

Device: Flame 2.2(319mb)(KitKat)(Shallow Flash)
Build ID: 20141104040207
Gaia: 3c50520982560ccba301474d1ac43706138fc851
Gecko: 54d05732f29b
Version: 36.0a1 (2.2)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0
-----------------------------------------------------------------------------
This issue does not occur on Flame 2.0

Result: Lockscreen does not appear

Flame 2.2

Device: Flame 2.2(319mb)(KitKat)(Shallow Flash)
Build ID: 20141104040207
Gaia: 3c50520982560ccba301474d1ac43706138fc851
Gecko: 54d05732f29b
Version: 36.0a1 (2.2)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Comment 2

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

The short flicker of the lock screen on 2.1 is not enough to block on.

[Blocking Requested - why for this release]:

However, on 2.2 the user can get completely locked out of their phone, with no way to get back in except by restart, or pulling the battery. This is why I am nominating this bug to block 2.2, even though it is not the earliest branch that this issue occurs on

Comment 3

[Joshua Mitchell (Inactive)]

Regression-window is not available - this issue occurs in the earliest 2.1 build we have

Environmental Variables:
Device: Flame 2.1
Build ID: 20140904062538
Gaia: a47ecb6368c015dd72148acde26413fd90ba3136
Gecko: ffb144a500a4
Gonk: Could not pull gonk.  Did you shallow Flash?
Version: 34.0a2 (2.1)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 4

[howie [:howie]]

Triage: blocking because it'll stuck

Comment 5

[Greg Weng [:snowmantw][:gweng][:λ]]

I've found it's hard to reproduce. And from logs, I noticed that this may happen when we instantiate LWN but the events aren't registered, since we can't even unlock it with 'lockscreen-request-unlock' event. However, after I add debugging log to make sure the events are all registered, I can't reproduce it anymore (timing issue?).

Is this bug only reproducible when you test with a newly refreshed device? If you have a workable LockScreen and then reboot again, is this bug still reproducible?

Comment 6

[Greg Weng [:snowmantw][:gweng][:λ]]

NI Alive for further opinions: from the logs I've watched that the event registration would happen during booting (init logo), since LWM should be initialized at that moment. So, either LWM initializes with some unknown errors so the events are unregistered, or LWM is good but some mysterious platform issue occurs when W/R mozSettings. I suspect that since even though LWM is broken, the slider inside LockScreen should receive touch events as usual. Nevertheless, when I can reproduce it, it looks like receive no events, too.

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Greg Weng [:snowmantw][:gweng][:λ] from comment #6)
> NI Alive for further opinions: from the logs I've watched that the event
> registration would happen during booting (init logo), since LWM should be
> initialized at that moment. So, either LWM initializes with some unknown
> errors so the events are unregistered, or LWM is good but some mysterious
> platform issue occurs when W/R mozSettings. I suspect that since even though
> LWM is broken, the slider inside LockScreen should receive touch events as
> usual. Nevertheless, when I can reproduce it, it looks like receive no
> events, too.

Visible but no touch event might be pointer-events: none; somewhere applies to lockscreenWindow mistakenly in window.css

Comment 8

[Greg Weng [:snowmantw][:gweng][:λ]]

Yes, but as I said, not only touch events broken, but LWM looks like receive nothing from my event dispatching via AppManager. Unless there are two broken parts for this bug (CSS + init), or the related events are all not received/handled.

Comment 9

[Greg Weng [:snowmantw][:gweng][:λ]]

And if you can reproduce the issue, could you add some log like

    console.log('>> register event:', type);

before the line
  
    https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/lockscreen_window_manager.js#L274

to see if the issue can be reproduced again? Since after that I can't reproduce it anymore. If so, it shows we have some timing issue here.

Comment 10

[[:SalvadorR]]

I am unable to get this issue to repro when testing on a newly refreshed device.

Comment 11

[Greg Weng [:snowmantw][:gweng][:λ]]

According to Comment 10, should we do a branch check again? And if it's not reproducible anymore, should we close the bug (and the blocker request)?

Comment 12

[howie [:howie]]

it's not reproducible in master 2.2. resolve worksforme.