1093796 - Do final Acceptance Testing on Event Wizard

Status: RESOLVED FIXED

(Webmaker Graveyard :: Events, defect)

Description

[Matt Thompson (@OpenMatt :OpenMatt)]

* Deployed to staging: https://welcome.mofostaging.net/event/start/

Comment 1

[Matt Thompson (@OpenMatt :OpenMatt)]

* Wex / David: flagging you to ensure we follow best practices for doing final QA 

* Andrew: flagging you to review from Product & Experience standpoint

Comment 2

[Andrew Sliwinski:thisandagain]

Here are some high-level notes:

Step 1 (Choose):
- Curious if we could make the entire div for each activity clickable vs. just the button at the bottom. I was tempted to just click on the icon vs. scroll to below the fold to find the button.
- The "(1)-(2)-(3)" header graphic appears to be scaled / stretched
- The connection between the "(2)-(3)" in the header graphic (just to the left of the "3") has a little transparency artifact in it

Step 2 (Details):
- Pressing "back" on the browser does not take me back to step 1
- Clicking on "(1) Choose" in the header does not take me back to step 1
- The new login system on step 2 didn't work
    - User: no response after entering email address and clicking "Sign in"
    - Console: 
        POST https://welcome.mofostaging.net/auth/v2/request 429 (Too Many Requests) white.min.js:4
        Uncaught TypeError: Cannot read property 'focus' of null white.min.js:8
- After logging in with persona, the sign in modal would not dismiss which blocked the rest of the form. I hid it using the inspector so I could continue
- We should pre-populate the "Activity Size" field to match the activity description in step 1. Or at least provide a default that is average / normal for most events (10? 20?)

Step 3 (Share):
- Feels like the CTA to share via Twitter / Facebook could be larger, but otherwise this screen feels pretty good and where you land after clicking on the event link makes sense.

Comment 3

[Andrew Sliwinski:thisandagain]

Step 4 (Email):
- In the post event creation email I received, the "From" is "Webmaker" but the email is signed from Amira
- It is signed by Amira twice. See full message body:

"Hi a,

I'm excited to hear you're throwing an event! To help you make it a success, we've compiled some tips and tricks. These resources will help you organize your event, get the most out of our teaching materials, work with local partners, gain press coverage, gather feedback, and more.

If you have any questions, don't hesitate to contact me. I'm here to help!

Cheers, 
Amira 
Webmaker Community Manager

Cheers, 
Amira 
Webmaker Community Manager"

Comment 4

[Matt Thompson (@OpenMatt :OpenMatt)]

Summarizing fixes required from Andrew's comment 2:

Step 1 (Choose):
a) make the entire div for each activity clickable vs. just the button at the bottom. 
b) fix header graphic. The "(1)-(2)-(3)" header graphic appears to be scaled / stretched
c) fix transparency artifact. The connection between the "(2)-(3)" in the header graphic (just to the left of the "3") has a little transparency artifact in it

Step 2 (Details):
a) Pressing "back" on the browser does not take me back to step 1
b) Clicking on "(1) Choose" in the header does not take me back to step 1

Comment 5

[Matt Thompson (@OpenMatt :OpenMatt)]

* Gavin: can you start on the fixes above? Summarized in comment 4. More context in comment 2.

Comment 6

[Gavin Suntop [:gvn]]

Sure. Do you just want the fixes in comment 4 or everything from 2 and 3 as well?

Comment 7

[paulj]

A few comments: 

The Activity titles for "Remix Your School" and "Music Video Mashup" change to their old titles in step 2. The event name in step 2 needs to change from "Hack Your High School" to "Remix Your School" and "YouTube Karaoke" should be "Music Video Mashup."

When creating a new account in step 2, I get an automated "Welcome to Webmaker" email that has a different set off CTA's and doesn't make sense in the context of the wizard funnel. Can we disable this message for people creating new accounts through Wizard?

I can't get past step 2 to comment on other parts ("Create Your Activity" doesn't do anything) but in regards to Andrew's Comment 3 that shouldn't be the email he received. That's the existing event email that was supposed to be disabled for wizard events and replaced with the one in https://bugzilla.mozilla.org/show_bug.cgi?id=1071935

Comment 8

[Gavin Suntop [:gvn]]

Attachment: https://github.com/mozilla/webmaker-landing-pages/pull/103

Comment 9

[Gavin Suntop [:gvn]]

PR 103 resolves issues from comment 4 and comment 7 (minus the email stuff as I'm not sure how to change that).

Comment 10

[Gavin Suntop [:gvn]]

This is re-staged if any of you want to take another pass.

https://welcome.mofostaging.net/event/start/

Comment 11

[paulj]

Looking pretty good. Still a few existing issues: 

Activity titles are now consistent on steps 1-3 but the old/wrong titles still exist on the actual event URL's.  Remix Your School and Music Video Mashup event pages need updating.  

Post-event email is still broken (broken/wrong email content).

Comment 12

[Matt Thompson (@OpenMatt :OpenMatt)]

* Back to Gavin for those fixes

Comment 13

[Gavin Suntop [:gvn]]

Attachment: https://github.com/mozilla/webmaker-landing-pages/pull/105

This PR makes the activity titles consistent.

Comment 14

[Gavin Suntop [:gvn]]

Jbuck, I'm not sure how to resolve the email issues pointed out above. Can you assist?

Comment 15

[Aki Rose Braun [:akirose]]

Comment on attachment 8518376 [details] [review]
https://github.com/mozilla/webmaker-landing-pages/pull/105

R+ once travis builds

Comment 16

[Jon Buckley [:jbuck]]

Emails will be updated in bug 1071935

Comment 17

[Gavin Suntop [:gvn]]

Matt, are we good to mark this resolved now?

Comment 18

[paulj]

Sorry, one additional comment. The actual activity pages - linked to via to from the event start page - still point to content hosted on the blog. 

With bug 1074913 we were supposed to have this content live on webmaker. Maybe that happened and the links just need updating?

Comment 19

[Matt Thompson (@OpenMatt :OpenMatt)]

* Good catch -- thanks Paul. 

* I'm not sure what the URLs for those are -- flagging Ali and Ricardo as they worked on that build bug:
Bug 1074913 - Build these three "Event Wizard" guides as pages on Webmaker.org

Comment 20

[Ali Al Dallal [:alicoding]]

These are not on production yet, but these are the URLs:

https://webmaker.mofostaging.net/en-US/remix-your-school
https://webmaker.mofostaging.net/en-US/private-eye
https://webmaker.mofostaging.net/en-US/music-video

Not sure why they are not up on production yet, but I guess we are holding that because of the new login?

Comment 21

[Matt Thompson (@OpenMatt :OpenMatt)]

Filed here: Bug 1096425 - Push activity guides from staging to production

Comment 22

[Ricardo Vazquez [:ricardo]]

I submitted a 2 tickets with some UI tweaks.

Comment 23

[Andrew Sliwinski:thisandagain]

Cross-browser QA items:

- In Safari 8.0, the user is immediately prompted to "Allow" / "Don't Allow" access to the user's location. This is off-putting as the site hasn't demonstrated why having access to the user's location is relevant / important.
- In Safari 8.0 if the user selects "Don't Allow" the site will keep prompting for location access until you either leave the page or select "Allow".

Additional feedback / QA items:
- The "Activity Size" field in step 2 should be pre-populated with "10 - 20" or some other default IMO.
- The email that the user receives is from "Webmaker <[e-mail]>" but is signed by Amira
- Had a few issues with login persisting between sessions. Multiple times I refreshed the site (same browser, same cookies, etc) and was again prompted to sign-in

Comment 24

[Andrew Sliwinski:thisandagain]

One more comment on the post-event email:

- The email body contains a line, "Your event is scheduled for 2014-12-11T02:00:00.000Z. On the day of your event, please send participants to the launch page for your activity." The date/time should be formatted in a human friendly way rather than ISO.

Comment 25

[paulj]

+1 to Andrew's comments. 

The email should come from Amira. If that's not possible because it's automated from webmaker, we can change the signatory to "The Webmaker Team." Prefer personalized from Amira but this is an alternative.

Comment 26

[Matt Thompson (@OpenMatt :OpenMatt)]

* Ok so final fixes required to close this ticket:

1) Clear final blocker: bug 1096963 
2) Resolve cross-browser issues. Don't prompt for location in Safari 8.0. (comment 23)
3) "Activity Size" field in step 2 should be pre-populated with "10 - 20"
4) Email tweak. filed in bug 1071935. 
5) Login persistence issue. Important, but not a blocker for this ticket. Let's file that and work it separately. Seems like a larger issue.

Comment 27

[Jon Buckley [:jbuck]]

Adding Laura's comments as a blocker; want to review that Matt?

Comment 28

[Matt Thompson (@OpenMatt :OpenMatt)]

* Jbuck: not a blocker

Comment 29

[Gavin Suntop [:gvn]]

Attachment: https://github.com/mozilla/webmaker-landing-pages/pull/115

Comment 30

[Gavin Suntop [:gvn]]

This PR (115) resolves 2 & 3 from comment 26. 

1 and 4 are filed. Agree that 5 should be a new ticket.

Comment 31

[Gavin Suntop [:gvn]]

Ok, all blocking issues have been fixed and merged to master.

Jbuck if you can redeploy to staging then we should be able to verify and resolve this ticket!

Comment 32

[Matt Thompson (@OpenMatt :OpenMatt)]

* Not clear what we need Jbuck to redeploy / what we need to close this -- Simon will follow up.

* Gavin: Jbuck's busy on log-in, so any advice / proposals?

Comment 33

[Jon Buckley [:jbuck]]

Anything merged to master gets deployed to staging, so we're all good here!

Comment 34

[Jon Buckley [:jbuck]]

Just gonna finish up that one last blocker before marking this as resolved.

Comment 35

[Gavin Suntop [:gvn]]

Ok, verified that my patches are applied to staging.

Comment 36

[Jon Buckley [:jbuck]]

We good.

Comment 37

[Jon Buckley [:jbuck]]

https://welcome.webmaker.org/event/start (will be live in a few minutes)