1093799 - TypeError: Cannot call method 'on' of undefined

Status: RESOLVED FIXED

(Testing Graveyard :: JSMarionette, defect)

Description

[Dale Harvey (:daleharvey)]

A large number of our intermittent tests fail with this, example output being 

11:57:59     INFO -  TEST-PASS | null | manipulate battery settings enable power save mode
11:57:59     INFO -  TEST-END | null | manipulate battery settings enable power save mode took 1216 ms
11:58:11     INFO -  TypeError: Cannot call method 'on' of undefined
11:58:11     INFO -      at Object.CommandStream (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/command-stream.js:23:12)
11:58:11     INFO -      at Object.<anonymous> (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/drivers/tcp.js:71:28)
11:58:11     INFO -      at waitForSocket (/builds/slave/test/gaia/node_modules/marionette-client/node_modules/socket-retry-connect/index.js:37:12)
11:58:11     INFO -      at timer._onTimeout (timers.js:210:16)
11:58:11     INFO -      at Timer.listOnTimeout [as ontimeout] (timers.js:110:15)
11:58:11     INFO -  make: *** [test-integration-test] Error 8
11:58:11    ERROR - Return code: 2
11:58:11     INFO - TinderboxPrint: gaia-integration-tests: <em class="testfail">T-FAIL</em>
11:58:11    ERROR - Tests exited with return code 2: harness failures
11:58:11    ERROR - # TBPL FAILURE #

(from http://ftp.mozilla.org/pub/mozilla.org/b2g/try-builds/gaiabld-ac9de658becc/gaia-try-linux64_gecko/gaia-try_ubuntu64_vm-b2gdt_test-gaia-js-integration-2-bm113-tests1-linux64-build118.txt.gz)

This isnt very useful, we should have some diagnostics of what happened to the socket listener / stack traces if b2g crashes etc

Comment 1

[James Lal [:lightsofapollo]]

putting this in my queue... we landed https://bugzilla.mozilla.org/show_bug.cgi?id=1081427 recently which is the ground work for custom error handling and a bunch of other stuff coming soon. I _think_ this is a crash but could also be some sort of data race that I have been suspicious about.

Comment 2

[Dale Harvey (:daleharvey)]

Attachment: Report b2g process error in mocha teardown

Comment 3

[Dale Harvey (:daleharvey)]

This just means we dont wait for the mocha timeout once the process crashes, makes it a little clearer

Comment 4

[James Lal [:lightsofapollo]]

Comment on attachment 8517987 [details] [review]
Report b2g process error in mocha teardown

https://github.com/mozilla-b2g/mocha-tbpl-reporter/commit/2cd9f85f658b3405ff532d6b18146e4ef64fa4d9