1093837 - User prompted to verify their email account when using the pre-verified email link

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P1)

Description

[krupa raj[:krupa]]

steps to reproduce:
0. Have Mark send out the pre-verified emails out
1. Load https://marketplace.allizom.org/admin/mail
2. Copy one of the pre-verified link and paste it into the browser
3. Enter your details


expected behavior:
User is logged into marketplace

actual behavior:
User is prompted to verify their account which makes the pre-verified flow a moot point.

screencast: http://screencast.com/t/nlJmf9myi

Comment 1

[Allen Short [:ashort]]

To avoid emailling AMO users, we should probably only email users who have logged in since the guillotine split. bug 973016 was closed on 2014-04-18, so start there.

Comment 2

[Mark Striemer [:mstriemer]]

https://github.com/mozilla/zamboni/commit/e65c4aaff6d7d1c88425d6cc12c1d69dc266c154

Got FxA to accept our stage tokens and updated our "aud" to match production FxA. Tested preverified flow with email, not logged in and logged in, all are working now.

Comment 3

[krupa raj[:krupa]]

I am still being prompted to verify my account when using the preverified flow on the phone.

Let me know if you a need a video. Account being used for test is [e-mail].

Comment 4

[Mark Striemer [:mstriemer]]

I just created an account on stage and this worked. Does it only happen on the phone? I'll try in simulator.

Comment 5

[Mark Striemer [:mstriemer]]

Just tried in the 2.1 simulator and it worked. How are you testing this? Here are my STR.

1. Create a test account through the shell (or ask me to create one).
2. Open Marketplace.
3. Run `require('storage').setItem('permissions', {})` (with `cd($('iframe'))` first if you're in an app).
4. Reload Marketplace.
5. Sign in.
6. Enter the email address when prompted.
7. You see the "Click the verification link..." box.
8. Check your email, click the link.
9. Create an account with the filled in email.
10. Your account is created.

I made these accounts for you on stage: [e-mail], [e-mail], [e-mail], [e-mail], [e-mail]

Comment 6

[Andy McKay]

I was able to do things on prod, here's a video:

https://www.dropbox.com/s/qd31a56eqh4leaw/fxa-pre-verified-take-two.mov?dl=0

Can we reproduce this on prod?

Comment 7

[krupa raj[:krupa]]

I was able to verify that this works.

Comment 8

[krupa raj[:krupa]]

verified fixed.